[py]: Additional type hinting for actions

symonk · symonk · commit 14b1befba0be · 2023-03-10T22:30:25.000Z
diff --git a/py/selenium/webdriver/common/actions/key_actions.py b/py/selenium/webdriver/common/actions/key_actions.py
@@ -14,6 +14,8 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+from __future__ import annotations
+
 from ..utils import keys_to_typing
 from .interaction import KEY
 from .interaction import Interaction
@@ -44,7 +46,7 @@ def send_keys(self, text):
             self.key_up(letter)
         return self
 
-    def _key_action(self, action, letter):
+    def _key_action(self, action, letter) -> KeyActions:
         meth = getattr(self.source, action)
         meth(letter)
         return self
diff --git a/py/selenium/webdriver/common/actions/key_input.py b/py/selenium/webdriver/common/actions/key_input.py
@@ -35,7 +35,7 @@ def create_key_down(self, key) -> None:
     def create_key_up(self, key) -> None:
         self.add_action(TypingInteraction(self, "keyUp", key))
 
-    def create_pause(self, pause_duration=0) -> None:
+    def create_pause(self, pause_duration: float = 0) -> None:
         self.add_action(Pause(self, pause_duration))
 
 
diff --git a/py/selenium/webdriver/common/actions/pointer_actions.py b/py/selenium/webdriver/common/actions/pointer_actions.py
@@ -194,7 +194,7 @@ def double_click(self, element=None):
         self.pointer_up(MouseButton.LEFT)
         return self
 
-    def pause(self, duration=0):
+    def pause(self, duration: float = 0):
         self.source.create_pause(duration)
         return self
 
diff --git a/py/selenium/webdriver/common/actions/pointer_input.py b/py/selenium/webdriver/common/actions/pointer_input.py
@@ -35,7 +35,14 @@ def __init__(self, kind, name):
         self.kind = kind
         self.name = name
 
-    def create_pointer_move(self, duration=DEFAULT_MOVE_DURATION, x=0, y=0, origin=None, **kwargs):
+    def create_pointer_move(
+        self,
+        duration=DEFAULT_MOVE_DURATION,
+        x: float = 0,
+        y: float = 0,
+        origin: typing.Optional[WebElement] = None,
+        **kwargs,
+    ):
         action = {"type": "pointerMove", "duration": duration, "x": x, "y": y, **kwargs}
         if isinstance(origin, WebElement):
             action["origin"] = {"element-6066-11e4-a52e-4f735466cecf": origin.id}
@@ -53,7 +60,7 @@ def create_pointer_up(self, button):
     def create_pointer_cancel(self):
         self.add_action({"type": "pointerCancel"})
 
-    def create_pause(self, pause_duration):
+    def create_pause(self, pause_duration: float) -> None:
         self.add_action({"type": "pause", "duration": int(pause_duration * 1000)})
 
     def encode(self):
diff --git a/py/selenium/webdriver/common/actions/wheel_actions.py b/py/selenium/webdriver/common/actions/wheel_actions.py
@@ -24,7 +24,7 @@ def __init__(self, source: WheelInput = None):
             source = WheelInput("wheel")
         super().__init__(source)
 
-    def pause(self, duration=0):
+    def pause(self, duration: float = 0):
         self.source.create_pause(duration)
         return self
 
diff --git a/py/selenium/webdriver/common/actions/wheel_input.py b/py/selenium/webdriver/common/actions/wheel_input.py
@@ -73,5 +73,5 @@ def create_scroll(self, x: int, y: int, delta_x: int, delta_y: int, duration: in
             }
         )
 
-    def create_pause(self, pause_duration: Union[int, float]) -> None:
+    def create_pause(self, pause_duration: float) -> None:
         self.add_action({"type": "pause", "duration": int(pause_duration * 1000)})

Original file line number	Diff line number	Diff line change
`@@ -73,5 +73,5 @@ def create_scroll(self, x: int, y: int, delta_x: int, delta_y: int, duration: in`
`73`	`73`	`}`
`74`	`74`	`)`
`75`	`75`
`76`		`- def create_pause(self, pause_duration: Union[int, float]) -> None:`
	`76`	`+ def create_pause(self, pause_duration: float) -> None:`
`77`	`77`	`self.add_action({"type": "pause", "duration": int(pause_duration * 1000)})`