Skip to content

Commit 11f7dde

Browse files
committed
[java] Fixing method in SafariDriver
I missed to push this diff :facepalm
1 parent ad8ef06 commit 11f7dde

1 file changed

Lines changed: 14 additions & 13 deletions

File tree

java/src/org/openqa/selenium/safari/SafariDriver.java

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
package org.openqa.selenium.safari;
1919

2020
import com.google.common.collect.ImmutableMap;
21+
2122
import org.openqa.selenium.Beta;
2223
import org.openqa.selenium.Capabilities;
2324
import org.openqa.selenium.WebDriverException;
@@ -68,7 +69,7 @@ public SafariDriver(Capabilities desiredCapabilities) {
6869
* @param safariOptions safari specific options / capabilities for the driver
6970
*/
7071
public SafariDriver(SafariOptions safariOptions) {
71-
this(SafariDriverService.createDefaultService(safariOptions), safariOptions);
72+
this(SafariDriverService.createDefaultService(), safariOptions);
7273
}
7374

7475
/**
@@ -91,6 +92,11 @@ public SafariDriver(SafariDriverService safariServer, SafariOptions safariOption
9192
debugger = new AddHasDebugger().getImplementation(getCapabilities(), getExecuteMethod());
9293
}
9394

95+
@Beta
96+
public static RemoteWebDriverBuilder builder() {
97+
return RemoteWebDriver.builder().oneOf(new SafariOptions());
98+
}
99+
94100
@Override
95101
public void setPermissions(String permission, boolean value) {
96102
Require.nonNull("Permission Name", permission);
@@ -109,6 +115,13 @@ public void attachDebugger() {
109115
debugger.attachDebugger();
110116
}
111117

118+
@Override
119+
public void setFileDetector(FileDetector detector) {
120+
throw new WebDriverException(
121+
"Setting the file detector only works on remote webdriver instances obtained " +
122+
"via RemoteWebDriver");
123+
}
124+
112125
private static class SafariDriverCommandExecutor extends DriverCommandExecutor {
113126
public SafariDriverCommandExecutor(DriverService service) {
114127
super(service, getExtraCommands());
@@ -121,16 +134,4 @@ private static Map<String, CommandInfo> getExtraCommands() {
121134
.build();
122135
}
123136
}
124-
125-
@Override
126-
public void setFileDetector(FileDetector detector) {
127-
throw new WebDriverException(
128-
"Setting the file detector only works on remote webdriver instances obtained " +
129-
"via RemoteWebDriver");
130-
}
131-
132-
@Beta
133-
public static RemoteWebDriverBuilder builder() {
134-
return RemoteWebDriver.builder().oneOf(new SafariOptions());
135-
}
136137
}

0 commit comments

Comments
 (0)