[java] Remove try/catch from tests

asolntsev · web-flow · commit 067ab3c9f337 · 2022-09-06T18:33:47.000+05:30
diff --git a/java/test/com/thoughtworks/selenium/HttpCommandProcessorUnitTest.java b/java/test/com/thoughtworks/selenium/HttpCommandProcessorUnitTest.java
@@ -17,12 +17,6 @@
 
 package com.thoughtworks.selenium;
 
-import static org.junit.jupiter.api.Assertions.assertArrayEquals;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.fail;
-import static org.mockito.Mockito.doReturn;
-import static org.mockito.Mockito.spy;
-
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;
@@ -33,6 +27,12 @@
 import java.net.HttpURLConnection;
 import java.net.URL;
 
+import static org.junit.jupiter.api.Assertions.assertArrayEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.fail;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.spy;
+
 /**
  * {@link com.thoughtworks.selenium.HttpCommandProcessor} unit test class.
  */
@@ -102,15 +102,12 @@ public void testResourcesClosedWhenIoeOnGetInputStream() {
   }
 
   @Test
-  public void testResourcesClosedWhenNoIoes() {
+  public void testResourcesClosedWhenNoIoes() throws IOException {
     IOEThrowingHttpCommandProcessor cmdProc = new IOEThrowingHttpCommandProcessor(
         "localhost", 4444, "*chrome", "http://www.google.com");
-    try {
-      cmdProc.getCommandResponseAsString("testCommand");
-      cmdProc.verifyClosedResources(true, true, true);
-    } catch (IOException ioe) {
-      fail();
-    }
+
+    cmdProc.getCommandResponseAsString("testCommand");
+    cmdProc.verifyClosedResources(true, true, true);
   }
 
   @Test
diff --git a/java/test/org/openqa/selenium/ExecutingJavascriptTest.java b/java/test/org/openqa/selenium/ExecutingJavascriptTest.java
@@ -45,7 +45,6 @@
 import static java.util.Collections.singletonList;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
-import static org.junit.jupiter.api.Assertions.fail;
 import static org.junit.jupiter.api.Assumptions.assumeTrue;
 import static org.openqa.selenium.By.id;
 import static org.openqa.selenium.testing.drivers.Browser.CHROME;
@@ -491,16 +490,12 @@ public void testShouldThrowAnExceptionWhenArgumentsWithStaleElementPassed() {
 
   @Test
   @Ignore(IE)
-  public void testShouldBeAbleToReturnADateObject() {
+  public void testShouldBeAbleToReturnADateObject() throws ParseException {
     driver.get(pages.simpleTestPage);
 
     String date = (String) executeScript("return new Date();");
 
-    try {
-      new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'").parse(date);
-    } catch (ParseException e) {
-      fail();
-    }
+    new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'").parse(date);
   }
 
   @Test
