[rb] update spec guards

titusfortner · titusfortner · commit 058d516f0e26 · 2022-09-04T11:41:05.000-05:00
diff --git a/rb/spec/integration/selenium/webdriver/action_builder_spec.rb b/rb/spec/integration/selenium/webdriver/action_builder_spec.rb
@@ -202,7 +202,7 @@ module WebDriver
           expect(element.attribute(:value)).to eq('Clicked')
         end
 
-        it 'moves to element with offset', exclude: {browser: :firefox, platform: :linux} do
+        it 'moves to element with offset' do
           driver.navigate.to url_for('javascriptPage.html')
           origin = driver.find_element(id: 'keyUpArea')
           destination = driver.find_element(id: 'clickField')
diff --git a/rb/spec/integration/selenium/webdriver/manager_spec.rb b/rb/spec/integration/selenium/webdriver/manager_spec.rb
@@ -81,10 +81,7 @@ module WebDriver
           expect(driver.manage.cookie_named('domain')[:domain]).to eq('.saucelabs.com')
         end
 
-        it 'should not allow domain to be set for localhost',
-           exclude: [{browser: %i[chrome edge],
-                      reason: "https://bugs.chromium.org/p/chromedriver/issues/detail?id=3733"}],
-           except: {browser: %i[safari safari_preview]} do
+        it 'should not allow domain to be set for localhost', except: {browser: %i[safari safari_preview]} do
           expect {
             driver.manage.add_cookie name: 'domain',
                                      value: 'localhost',
diff --git a/rb/spec/integration/selenium/webdriver/shadow_root_spec.rb b/rb/spec/integration/selenium/webdriver/shadow_root_spec.rb
@@ -17,7 +17,6 @@
 # specific language governing permissions and limitations
 # under the License.
 
-
 require_relative 'spec_helper'
 
 module Selenium
diff --git a/rb/spec/integration/selenium/webdriver/takes_screenshot_spec.rb b/rb/spec/integration/selenium/webdriver/takes_screenshot_spec.rb
@@ -109,7 +109,7 @@ def save_screenshot_and_assert(source, path)
           end
         end
 
-        it 'does not take full page screenshot', exclude: {browser: :firefox} do
+        it 'does not take full page screenshot', except: {browser: :firefox} do
           expect {
             driver.save_screenshot path, full_page: true
           }.to raise_exception(Error::UnsupportedOperationError, /Full Page Screenshots are not supported/)
diff --git a/rb/spec/integration/selenium/webdriver/window_spec.rb b/rb/spec/integration/selenium/webdriver/window_spec.rb
@@ -60,7 +60,10 @@ module WebDriver
         expect(pos.y).to be >= 0
       end
 
-      it 'sets the position of the current window' do
+      it 'sets the position of the current window',
+         except: {browser: :firefox,
+                  window_manager: false,
+                  reason: 'https://github.com/mozilla/geckodriver/issues/2042'} do
         pos = window.position
 
         target_x = pos.x + 10
@@ -86,7 +89,10 @@ module WebDriver
         expect(rect.height).to be >= 0
       end
 
-      it 'sets the rect of the current window' do
+      it 'sets the rect of the current window',
+         except: {browser: :firefox,
+                  window_manager: false,
+                  reason: 'https://github.com/mozilla/geckodriver/issues/2042'} do
         rect = window.rect
 
         target_x = rect.x + 10
@@ -116,12 +122,7 @@ module WebDriver
         expect(new_size.height).to be > old_size.height
       end
 
-      # Edge: Not Yet - https://dev.windows.com/en-us/microsoft-edge/platform/status/webdriver/details/
-      # https://github.com/mozilla/geckodriver/issues/1281
-      it 'can make window full screen', only: {window_manager: true},
-                                        exclude: [{driver: :remote, browser: :firefox, platform: :linux},
-                                                  {driver: :remote, browser: :safari},
-                                                  {browser: %i[chrome edge]}] do
+      it 'can make window full screen', except: {window_manager: false, browser: :firefox} do
         window.size = old_size = Dimension.new(700, 700)
 
         window.full_screen
@@ -132,11 +133,7 @@ module WebDriver
         expect(new_size.height).to be > old_size.height
       end
 
-      # Edge: Not Yet - https://dev.windows.com/en-us/microsoft-edge/platform/status/webdriver/details/
-      # https://github.com/mozilla/geckodriver/issues/1281
-      it 'can minimize the window', only: {window_manager: true},
-                                    exclude: [{driver: :remote, browser: :firefox, platform: :linux},
-                                              {driver: :remote, browser: :safari}] do
+      it 'can minimize the window', only: {window_manager: true} do
         window.minimize
         expect(driver.execute_script('return document.hidden;')).to be true
       end
diff --git a/rb/spec/unit/selenium/webdriver/support/cdp_client_generator_spec.rb b/rb/spec/unit/selenium/webdriver/support/cdp_client_generator_spec.rb
@@ -17,7 +17,6 @@
 # specific language governing permissions and limitations
 # under the License.
 
-
 require File.expand_path('../spec_helper', __dir__)
 require 'selenium/webdriver/support/cdp_client_generator'
 
