[java] Overriding methods to have main platform names lowercase

diemol · diemol · commit 000cb086e988 · 2023-05-04T13:23:03.000+02:00
Fixes #11952
diff --git a/java/src/org/openqa/selenium/Platform.java b/java/src/org/openqa/selenium/Platform.java
@@ -38,6 +38,11 @@ public enum Platform {
     public Platform family() {
       return null;
     }
+
+    @Override
+    public String toString() {
+      return "windows";
+    }
   },
 
   /**
@@ -132,6 +137,11 @@ public String toString() {
     public Platform family() {
       return null;
     }
+
+    @Override
+    public String toString() {
+      return "mac";
+    }
   },
 
   SNOW_LEOPARD("snow leopard", "os x 10.6", "macos 10.6") {
@@ -284,6 +294,11 @@ public Platform family() {
     public Platform family() {
       return UNIX;
     }
+
+    @Override
+    public String toString() {
+      return "linux";
+    }
   },
 
   ANDROID("android", "dalvik") {
@@ -311,6 +326,12 @@ public Platform family() {
     public boolean is(Platform compareWith) {
       return this == compareWith;
     }
+
+    @Override
+    public String toString() {
+      return "any";
+    }
+
   };
 
   private static Platform current;
diff --git a/java/test/org/openqa/selenium/remote/RemoteWebElementTest.java b/java/test/org/openqa/selenium/remote/RemoteWebElementTest.java
@@ -80,7 +80,7 @@ void canHandleWebDriverExceptionThrownByCommandExecutor() {
       .withMessageContaining(String.format(
         "Command: [%s, clickElement {id=%s}]", fixture.driver.getSessionId(), fixture.element.getId()))
       .withMessageContaining(String.format(
-        "Element: [[RemoteWebDriver: cheese on WINDOWS (%s)] -> id: test]", fixture.driver.getSessionId()));
+        "Element: [[RemoteWebDriver: cheese on windows (%s)] -> id: test]", fixture.driver.getSessionId()));
 
     fixture.verifyCommands(
       new CommandPayload(
@@ -106,7 +106,7 @@ void canHandleGeneralExceptionThrownByCommandExecutor() {
       .withMessageContaining(String.format(
         "Command: [%s, clickElement {id=%s}]", fixture.driver.getSessionId(), fixture.element.getId()))
       .withMessageContaining(String.format(
-        "Element: [[RemoteWebDriver: cheese on WINDOWS (%s)] -> id: test]", fixture.driver.getSessionId()))
+        "Element: [[RemoteWebDriver: cheese on windows (%s)] -> id: test]", fixture.driver.getSessionId()))
       .havingCause()
       .withMessage("BOOM!!!");
 
@@ -134,7 +134,7 @@ void canHandleWebDriverExceptionReturnedByCommandExecutor() {
       .withMessageContaining(String.format(
         "Command: [%s, clickElement {id=%s}]", fixture.driver.getSessionId(), fixture.element.getId()))
       .withMessageContaining(String.format(
-        "Element: [[RemoteWebDriver: cheese on ANY (%s)] -> id: test]", fixture.driver.getSessionId()));
+        "Element: [[RemoteWebDriver: cheese on any (%s)] -> id: test]", fixture.driver.getSessionId()));
 
     fixture.verifyCommands(
       new CommandPayload(
@@ -160,7 +160,7 @@ void canHandleResponseWithErrorCodeButNoExceptionReturnedByCommandExecutor() {
       .withMessageContaining(String.format(
         "Command: [%s, clickElement {id=%s}]", fixture.driver.getSessionId(), fixture.element.getId()))
       .withMessageContaining(String.format(
-        "Element: [[RemoteWebDriver: cheese on ANY (%s)] -> id: test]", fixture.driver.getSessionId()));
+        "Element: [[RemoteWebDriver: cheese on any (%s)] -> id: test]", fixture.driver.getSessionId()));
 
     fixture.verifyCommands(
       new CommandPayload(
diff --git a/java/test/org/openqa/selenium/support/ui/WebDriverWaitTest.java b/java/test/org/openqa/selenium/support/ui/WebDriverWaitTest.java
@@ -77,7 +77,7 @@ void shouldIncludeRemoteInfoForWrappedDriverTimeout() throws IOException {
 
     assertThatExceptionOfType(TimeoutException.class)
       .isThrownBy(() -> wait.until(d -> false))
-      .withMessageContaining("Capabilities {platformName: ANY}")
+      .withMessageContaining("Capabilities {platformName: any}")
         .withMessageContaining("Session ID: foo");
   }
 

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ void shouldIncludeRemoteInfoForWrappedDriverTimeout() throws IOException {`
`77`	`77`
`78`	`78`	`assertThatExceptionOfType(TimeoutException.class)`
`79`	`79`	`.isThrownBy(() -> wait.until(d -> false))`
`80`		`- .withMessageContaining("Capabilities {platformName: ANY}")`
	`80`	`+ .withMessageContaining("Capabilities {platformName: any}")`
`81`	`81`	`.withMessageContaining("Session ID: foo");`
`82`	`82`	`}`
`83`	`83`