Skip to content

Remove jQuery in Utils and Translation#6233

Merged
kevin-brown merged 4 commits into
select2:developfrom
sabas:develop
May 25, 2026
Merged

Remove jQuery in Utils and Translation#6233
kevin-brown merged 4 commits into
select2:developfrom
sabas:develop

Conversation

@sabas
Copy link
Copy Markdown
Contributor

@sabas sabas commented Mar 3, 2023

This pull request includes a

  • Bug fix
  • New feature
  • Translation

The following changes were made

  • I tried to remove jQuery from two files to see if I can help somehow
  • I ran grunt test and all passed

If this is related to an existing ticket, include a link to it as well.

Comment thread src/js/select2/translation.js Outdated
@sabas
Copy link
Copy Markdown
Contributor Author

sabas commented Apr 4, 2024

#6196

Comment thread src/js/select2/utils.js Outdated
Comment thread src/js/select2/utils.js Outdated
sabas and others added 4 commits May 24, 2026 20:03
Apply suggestion from review: use computedStyle.height/width directly
in hasScroll instead of manually summing padding values.

Fix GetData to convert attribute name format to dataset property key
format (e.g. 'foo-bar' -> 'fooBar') per the HTML spec, which fixes
the 'with nesting' data attributes test.
@kevin-brown kevin-brown enabled auto-merge (squash) May 25, 2026 00:13
@kevin-brown kevin-brown merged commit 73c8063 into select2:develop May 25, 2026
3 checks passed
kevin-brown added a commit that referenced this pull request May 26, 2026
- Remove '(unreleased)' marker from the 4.1.0 heading
- Add new features: jQuery 4.0.0 support (#6332), originalEvent in
  close trigger args (#6079)
- Add bug fixes: placeholder misalignment (#6277), RTL choice remove
  button (#6257), digit-only data-placeholder (#6297), AJAX unselection
  with non-string IDs (#6241, #6335), optgroup child string coercion (#6338)
- Add translations: lb (#6131), ug (#6166), ar (#6175), zh-TW (#6157),
  id (#6153), tr (#6123), ro (#6190), de/es/fr/pt/pt-BR (#6132),
  pl (#6097, #6377), nb (#6213), fa (#6258), nl (#6269), pt-BR typo
  (#6200), missing bs/ca/da/fi strings (#6305)
- Add miscellaneous: native DOM replacements for jQuery attr/removeAttr
  (#6227, #6228), classList.add (#6229), jQuery removal from Utils and
  Translation (#6233), prop() removal (#6289), NPM trusted publishing
  (#6405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants