Fix: Update OffsetCommit CommittedLeaderEpoch to v6 - #1335
Merged
Conversation
LeonHartley
changed the title
LeonHartley
changed the title
petedannemann
previously approved these changes
May 14, 2025
petedannemann
self-requested a review
May 14, 2025 19:50
Contributor
|
@LeonHartley this looks good but can you merge main into your PR? I see the tests were failing before but those logs have expired in CircleCI. It seems unlikely they are failing now but I just want to verify |
Contributor
Author
|
@petedannemann cheers, I have updated with latest main now |
Contributor
Author
|
I noticed the TestOffsetCommitRequest tests were now failing due to them using the wrong protocol version too, I've updated those tests now and verified that they pass. |
LeonHartley
force-pushed
the
main
branch
2 times, most recently
from
May 15, 2025 20:09
87380c6 to
b649bde
Compare
ashishkf
pushed a commit
to kloudfuse/kafka-go
that referenced
this pull request
Aug 4, 2026
* Update OffsetCommit CommittedLeaderEpoch to v6, fixes segmentio#1334 * update OffsetCommitRequest test to use correct protocol version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.