fix: data race in roundrobin balancer - #1251
Merged
Merged
Conversation
petedannemann
marked this pull request as ready for review
December 12, 2023 21:50
|
We encountered this issue as well, would be great to get this merged soonish :) |
LKaemmerling
approved these changes
Dec 13, 2023
|
I´m experiencing the same issue, our tests are failing when checking with |
4ND3R50N
approved these changes
Dec 13, 2023
|
Quickfix (without this MR, but this MR is preferred): w := &kafka.Writer{
Addr: kafka.TCP("localhost:9092", "localhost:9093", "localhost:9094"),
Topic: "topic-A",
Balancer: &kafka.RoundRobin{
ChunkSize: 1,
},
} |
erushing
approved these changes
Dec 13, 2023
Contributor
Author
|
That was fast! thank u guys! |
ashishkf
pushed a commit
to kloudfuse/kafka-go
that referenced
this pull request
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1232 introduced a data race in the roundrobin balancer. It isn't a meaningful one, but still shows up when you use kafka-go as a library and run
go test -race