Add RawProduce API - #1233
Merged
Merged
Conversation
added 30 commits
October 18, 2023 19:29
This reverts commit 47882d1.
apacker
marked this pull request as ready for review
November 16, 2023 17:57
petedannemann
left a comment
petedannemann
left a comment
Contributor
There was a problem hiding this comment.
🚀 great work, two small comments for now. I'll think this over a bit more and re-review later this week
Co-authored-by: Peter Dannemann <[email protected]>
petedannemann
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
RawProduceAPI to the client. The background/context for this API is: we have an internal system that does buffering of Kafka messages on disk, and needs to flush that data to Kafka without having to decode/re-encode the data and incur a 2x cost of compression/encoding. In this context, it would be optimal to be able to pass a raw/pre-encodedRecordSetto the Produce API, hence the introduction of a newRawProduceinterface.Notes:
ProduceResponsetype is reused as there's no reason to introduce a new response type.OverrideTypeMessageinterface.