Skip to content

support userscramcredentials apis - #1168

Merged
petedannemann merged 13 commits into
mainfrom
userscramcredentials
Jul 28, 2023
Merged

support userscramcredentials apis#1168
petedannemann merged 13 commits into
mainfrom
userscramcredentials

Conversation

@petedannemann

@petedannemann petedannemann commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

Support userscramcredentials APIs

DescribeUserScramCredentials API Docs

AlterUserScramCredentials API Docs

I based this PR on similar work done here #1119

@petedannemann
petedannemann marked this pull request as ready for review July 20, 2023 17:38
Comment thread describeuserscramcredentials.go Outdated
Comment thread alteruserscramcredentials_test.go

@hhahn-tw hhahn-tw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread alteruserscramcredentials_test.go Outdated
Comment thread alteruserscramcredentials_test.go Outdated
@petedannemann
petedannemann marked this pull request as draft July 21, 2023 17:37
@petedannemann
petedannemann marked this pull request as ready for review July 24, 2023 20:38
Comment thread alteruserscramcredentials.go Outdated
Comment thread alteruserscramcredentials.go Outdated
@petedannemann
petedannemann requested a review from rhansen2 July 28, 2023 15:37
@petedannemann
petedannemann merged commit 6193fa9 into main Jul 28, 2023
@petedannemann
petedannemann deleted the userscramcredentials branch July 28, 2023 16:12
ashishkf pushed a commit to kloudfuse/kafka-go that referenced this pull request Aug 4, 2026
* userscramcredentials protocols

* alteruserscramcredentials working

* describeuserscramcredentials working

* gofmt -s -w alteruserscramcredentials_test.go

* fix typo

* add tests for deletion

* gofmt

* improve test

* separate alteruserscramcredentials_test and describeuserscramcredentials_test

* add protocol tests

* remove unused v1 constant

* change iterations from int32 to int

* keep errors with results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants