Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

Codecov report generation using ava-nyc #148

Closed
suphalb wants to merge 18 commits into from
Closed

Codecov report generation using ava-nyc #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6eed952
Codecov report generation using ava-nyc
suphalb Jan 11, 2018
e3d4834
readme.md update
suphalb Jan 11, 2018
a21ac9c
Merge branch 'master' of https://github.com/segmentio/analytics-node
suphalb Jan 13, 2018
33ea5df
readme file update
suphalb Jan 13, 2018
2f01d4f
readme file update
suphalb Jan 13, 2018
1764f89
codecov circleci integration
suphalb Jan 16, 2018
020955c
Upstream Update
suphalb Jan 16, 2018
01caa9c
circleci config file update
suphalb Jan 16, 2018
2f1c798
CircleCI integration config update
suphalb Jan 16, 2018
94924b6
CircleCI config adjustments
suphalb Jan 16, 2018
764b633
review corrections
suphalb Jan 16, 2018
415c5c0
review & CI build corrections
suphalb Jan 16, 2018
da475b6
CI build fix
suphalb Jan 16, 2018
b0b7874
ConfigCI fix
suphalb Jan 16, 2018
877a3f0
indention fix
suphalb Jan 16, 2018
fb1babf
readme file revert for space fix etc
suphalb Jan 17, 2018
d80ee3b
some mistake fixes
suphalb Jan 17, 2018
c3da3a3
CI yml line formatting
suphalb Jan 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
node_modules
node_modules
coverage
.nyc_output
coverage.lcov
Copy link
Copy Markdown

@vadimdemedes vadimdemedes Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to ignore coverage.lcov, if you're piping output from nyc to coveralls, like I mentioned in the comment below.

Copy link
Copy Markdown
Author

@suphalb suphalb Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so you mean i should push all of those dir/files with all my local reports & meta data i used for my local test bed? Should not they be ignored like npm rebuild as they will be created always while codecov report generation and uploading via nyc process will be running? Please suggest.

Copy link
Copy Markdown

@vadimdemedes vadimdemedes Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was talking only about coverage.lcov. But since I was thinking about coveralls and piping output before, it can stay there.

2 changes: 2 additions & 0 deletions circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ test:
- nvm use 4; npm rebuild &> /dev/null; npm run testci
- nvm use 6; npm rebuild &> /dev/null; npm run testci
- nvm use 8; npm rebuild &> /dev/null; npm run testci
post:
- npm run report-coverage
9 changes: 6 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@
],
"scripts": {
"size": "size-limit",
"test": "standard && ava",
Copy link
Copy Markdown
Contributor

@f2prateek f2prateek Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove the test command (this is still used locally).

Copy link
Copy Markdown
Author

@suphalb suphalb Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rectified.

"testci": "standard && ava && npm run size",
"test": "standard && nyc ava --tap",
"testci": "standard && nyc ava --tap && npm run size",
Copy link
Copy Markdown

@vadimdemedes vadimdemedes Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's --tap for? It doesn't affect coverage or reporting.

"prepublish": "npm run check-deps",
"check-deps": "nsp check"
"check-deps": "nsp check",
"report-coverage": "nyc report --reporter=lcov > coverage.lcov && codecov"
},
"files": [
"index.js",
Expand Down Expand Up @@ -55,9 +56,11 @@
"ava": "^0.24.0",
"basic-auth": "^2.0.0",
"body-parser": "^1.17.1",
"codecov": "^3.0.0",
"delay": "^2.0.0",
"express": "^4.15.2",
"nsp": "^3.1.0",
"nyc": "^11.4.1",
"pify": "^3.0.0",
"sinon": "^4.1.3",
"standard": "^10.0.3",
Expand Down