fix: unbreak and optimize harden-flatpak script#962
Merged
RoyalOughtness merged 3 commits intosecureblue:livefrom Mar 23, 2025
Merged
fix: unbreak and optimize harden-flatpak script#962RoyalOughtness merged 3 commits intosecureblue:livefrom
RoyalOughtness merged 3 commits intosecureblue:livefrom
Conversation
RoyalOughtness
approved these changes
Mar 23, 2025
RKNF404
approved these changes
Mar 23, 2025
HastD
approved these changes
Mar 23, 2025
RoyalOughtness
pushed a commit
to RoyalOughtness/secureblue-dev
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
harden-flatpakscript is broken since the ShellCheck PR, due to it previously relying on the$flatpak_idvariable being unquoted for applying the hardening globally. With the variable now quoted, it is passed as an empty argument (instead of none at all) to the flatpak command, which expects a valid app ID and trips because''(empty) is not a valid app ID.Discord support thread for reference:
https://discord.com/channels/1202086019298500629/1353322889578942574
This PR makes it work again and also optimizes it a bit.
Note: The ujust variable
{{ FLATPAK }}wasn't quoted before, because ShellCheck can't understand them, but as far as I'm aware they should be quoted as well to prevent the same issues as with bash-native variables.