fix: make shell script changes recommended by ShellCheck#948
Merged
RoyalOughtness merged 18 commits intosecureblue:livefrom Mar 20, 2025
Merged
fix: make shell script changes recommended by ShellCheck#948RoyalOughtness merged 18 commits intosecureblue:livefrom
RoyalOughtness merged 18 commits intosecureblue:livefrom
Conversation
Signed-off-by: Daniel Hast <[email protected]>
Signed-off-by: Daniel Hast <[email protected]>
Signed-off-by: Daniel Hast <[email protected]>
Collaborator
|
looks like there are a couple actions we can use too? https://github.com/marketplace?query=ShellCheck&type=actions |
Signed-off-by: Daniel Hast <[email protected]>
Signed-off-by: Daniel Hast <[email protected]>
Signed-off-by: Daniel Hast <[email protected]>
Collaborator
Author
|
Okay, this is ready for review. I don't know why the automated tests are failing, btw—it's saying the justfile variable |
Signed-off-by: Daniel Hast <[email protected]>
Signed-off-by: Daniel Hast <[email protected]>
RoyalOughtness
previously approved these changes
Mar 18, 2025
Signed-off-by: Daniel Hast <[email protected]>
RoyalOughtness
previously approved these changes
Mar 19, 2025
pxlkng
approved these changes
Mar 19, 2025
Signed-off-by: Daniel Hast <[email protected]>
Signed-off-by: Daniel Hast <[email protected]>
RKNF404
approved these changes
Mar 20, 2025
Closed
Signed-off-by: Daniel Hast <[email protected]>
RoyalOughtness
approved these changes
Mar 20, 2025
RoyalOughtness
pushed a commit
to RoyalOughtness/secureblue-dev
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains various minor changes to shell scripts suggested by ShellCheck. None of these changes should substantively change script behavior except to fix outright errors. The only major errors I found are in the part of
audit.justthat checks for sysctl overrides (which was completely broken and now works, at least on my system)—reviewers, please double-check my work on that.