fix: toggle-mac-randomization: correct logic to allow "random" option#944
Merged
RoyalOughtness merged 5 commits intosecureblue:livefrom Mar 18, 2025
Merged
fix: toggle-mac-randomization: correct logic to allow "random" option#944RoyalOughtness merged 5 commits intosecureblue:livefrom
RoyalOughtness merged 5 commits intosecureblue:livefrom
Conversation
… the "random" option currently the user's choice is ignored, because reusing the randomization_level variable causes the else case to run regardless of the user's choice.
RKNF404
approved these changes
Mar 16, 2025
HastD
approved these changes
Mar 17, 2025
Collaborator
|
Good catch, we really need static analysis to catch this stuff early. |
RoyalOughtness
approved these changes
Mar 17, 2025
RoyalOughtness
pushed a commit
to RoyalOughtness/secureblue-dev
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the user's choice is ignored, and the
elsecase always runs regardless of the user's choice. Using double brackets fixes the logic.