Skip to content

fix: MOTD broken after bluebuild rebase#940

Merged
RoyalOughtness merged 2 commits intosecureblue:livefrom
greenrd:bugfix/motd
Mar 17, 2025
Merged

fix: MOTD broken after bluebuild rebase#940
RoyalOughtness merged 2 commits intosecureblue:livefrom
greenrd:bugfix/motd

Conversation

@greenrd
Copy link
Copy Markdown
Contributor

@greenrd greenrd commented Mar 15, 2025

After doing a bluebuild rebase (which I got working by creating a fake sudo script that simply calls run0), the MOTD breaks because the image is now a local tarball file.

But %IMAGE_TAG% is unused in the MOTD, so simply avoid substituting it in.

@greenrd greenrd requested a review from RoyalOughtness as a code owner March 15, 2025 13:58
@RoyalOughtness
Copy link
Copy Markdown
Collaborator

fake sudo script that simply calls run0

just use a root shell by calling run0 on its own, if you need

bluebuild rebase

to what image?

This change seems fine since IMAGE_TAG is unused, but I don't get how it relates to the description 🙂

@greenrd
Copy link
Copy Markdown
Contributor Author

greenrd commented Mar 16, 2025

fake sudo script that simply calls run0

just use a root shell by calling run0 on its own, if you need

The reason I felt I had to create a script was the bluebuild rebase command invokes sudo, and I didn't want to elevate privileges unnecessarily by running the whole bluebuild operation under run0. However, it does call sudo a lot, which makes the number of run0 password popups annoying, so maybe I will run the whole thing under run0 next time.

bluebuild rebase

to what image?

To the image that bluebuild builds. That is what the bluebuild rebase command does - it builds my custom image and then immediately rebases to it if the build is successful.

This change seems fine since IMAGE_TAG is unused, but I don't get how it relates to the description 🙂

Hope it's clear now.

I'll now try to amend my commit to sign it, as it's listed as a requirement above, and then force-push.

@RoyalOughtness
Copy link
Copy Markdown
Collaborator

@greenrd approved, thanks for the explanation

%IMAGE_TAG% is unused in the MOTD, so simply avoid substituting it in
@greenrd
Copy link
Copy Markdown
Contributor Author

greenrd commented Mar 16, 2025

OK, I signed the commit.

@RoyalOughtness RoyalOughtness merged commit 845de99 into secureblue:live Mar 17, 2025
7 of 8 checks passed
@greenrd greenrd deleted the bugfix/motd branch April 12, 2025 11:47
RoyalOughtness pushed a commit to RoyalOughtness/secureblue-dev that referenced this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants