feat: add ujust toggle for dhcp hostname sending#1937
Merged
HastD merged 11 commits intosecureblue:livefrom Feb 24, 2026
Merged
feat: add ujust toggle for dhcp hostname sending#1937HastD merged 11 commits intosecureblue:livefrom
HastD merged 11 commits intosecureblue:livefrom
Conversation
HastD
requested changes
Feb 17, 2026
files/system/usr/libexec/secureblue/dhcp_hostname_sending_main.py
Outdated
Show resolved
Hide resolved
files/system/usr/libexec/secureblue/inner/dhcp_hostname_sending.py
Outdated
Show resolved
Hide resolved
files/system/usr/libexec/secureblue/inner/dhcp_hostname_sending.py
Outdated
Show resolved
Hide resolved
HastD
requested changes
Feb 19, 2026
Collaborator
HastD
left a comment
HastD
left a comment
There was a problem hiding this comment.
Just a couple small things to fix but other than that it looks good.
files/system/usr/libexec/secureblue/inner/dhcp_hostname_sending.py
Outdated
Show resolved
Hide resolved
files/system/usr/libexec/secureblue/inner/dhcp_hostname_sending.py
Outdated
Show resolved
Hide resolved
HastD
reviewed
Feb 19, 2026
files/system/usr/libexec/secureblue/dhcp_hostname_sending_main.py
Outdated
Show resolved
Hide resolved
HastD
previously approved these changes
Feb 19, 2026
files/system/usr/libexec/secureblue/dhcp_hostname_sending_main.py
Outdated
Show resolved
Hide resolved
HastD
approved these changes
Feb 23, 2026
RoyalOughtness
approved these changes
Feb 24, 2026
dimhollowcrypt
force-pushed
the
dhcp-hostname-sending-toggle
branch
from
a1d5b9c to
9afc034
Compare
1 task
PhysicsIsAwesome
pushed a commit
to PhysicsIsAwesome/secureblue
that referenced
this pull request
Mar 1, 2026
* feat: add ujust toggle for dhcp hostname sending * fix: usage correction * fix: address codacy issues, improve restart_nm * fix: further address codacy issues * chore: remove unnecessary nosec comments * refactor: replace internal logic with utils.parse_basic_toggle_args * refactor: remove multiple calls to sys.exit * fix: minor improvement to restart_nm * fix: address formatting issues * fix: remove redundant Path check * fix: use ToggleMode.OFF instead of hardcoded string
PhysicsIsAwesome
pushed a commit
to PhysicsIsAwesome/secureblue
that referenced
this pull request
Mar 1, 2026
* feat: add ujust toggle for dhcp hostname sending * fix: usage correction * fix: address codacy issues, improve restart_nm * fix: further address codacy issues * chore: remove unnecessary nosec comments * refactor: replace internal logic with utils.parse_basic_toggle_args * refactor: remove multiple calls to sys.exit * fix: minor improvement to restart_nm * fix: address formatting issues * fix: remove redundant Path check * fix: use ToggleMode.OFF instead of hardcoded string
RKNF404
pushed a commit
to RKNF404/secureblue
that referenced
this pull request
Mar 1, 2026
* feat: add ujust toggle for dhcp hostname sending * fix: usage correction * fix: address codacy issues, improve restart_nm * fix: further address codacy issues * chore: remove unnecessary nosec comments * refactor: replace internal logic with utils.parse_basic_toggle_args * refactor: remove multiple calls to sys.exit * fix: minor improvement to restart_nm * fix: address formatting issues * fix: remove redundant Path check * fix: use ToggleMode.OFF instead of hardcoded string
PhysicsIsAwesome
pushed a commit
to PhysicsIsAwesome/secureblue
that referenced
this pull request
Mar 1, 2026
* feat: add ujust toggle for dhcp hostname sending * fix: usage correction * fix: address codacy issues, improve restart_nm * fix: further address codacy issues * chore: remove unnecessary nosec comments * refactor: replace internal logic with utils.parse_basic_toggle_args * refactor: remove multiple calls to sys.exit * fix: minor improvement to restart_nm * fix: address formatting issues * fix: remove redundant Path check * fix: use ToggleMode.OFF instead of hardcoded string
PhysicsIsAwesome
pushed a commit
to PhysicsIsAwesome/secureblue
that referenced
this pull request
Mar 4, 2026
* feat: add ujust toggle for dhcp hostname sending * fix: usage correction * fix: address codacy issues, improve restart_nm * fix: further address codacy issues * chore: remove unnecessary nosec comments * refactor: replace internal logic with utils.parse_basic_toggle_args * refactor: remove multiple calls to sys.exit * fix: minor improvement to restart_nm * fix: address formatting issues * fix: remove redundant Path check * fix: use ToggleMode.OFF instead of hardcoded string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a ujust script to toggle whether NetworkManager will send the system's static hostname to the DHCP server.