fix: set LANG to ensure msginit works properly in update_po.py#1924
Merged
EsseLowNitro merged 2 commits intosecureblue:livefrom Feb 13, 2026
Merged
fix: set LANG to ensure msginit works properly in update_po.py#1924EsseLowNitro merged 2 commits intosecureblue:livefrom
EsseLowNitro merged 2 commits intosecureblue:livefrom
Conversation
Since `msginit` is used to generate the PO file for the `en_US` locale (which is the locale used for translatable strings in the source code), the `LANG` environment variable should be set to the same locale. Also use shell built-ins to avoid unnecessary external command calls in `localization.sh`.
RoyalOughtness
approved these changes
Feb 9, 2026
EsseLowNitro
approved these changes
Feb 13, 2026
PhysicsIsAwesome
pushed a commit
to PhysicsIsAwesome/secureblue
that referenced
this pull request
Mar 1, 2026
…eblue#1924) Since `msginit` is used to generate the PO file for the `en_US` locale (which is the locale used for translatable strings in the source code), the `LANG` environment variable should be set to the same locale. Also use shell built-ins to avoid unnecessary external command calls in `localization.sh`.
PhysicsIsAwesome
pushed a commit
to PhysicsIsAwesome/secureblue
that referenced
this pull request
Mar 1, 2026
…eblue#1924) Since `msginit` is used to generate the PO file for the `en_US` locale (which is the locale used for translatable strings in the source code), the `LANG` environment variable should be set to the same locale. Also use shell built-ins to avoid unnecessary external command calls in `localization.sh`.
RKNF404
pushed a commit
to RKNF404/secureblue
that referenced
this pull request
Mar 1, 2026
…eblue#1924) Since `msginit` is used to generate the PO file for the `en_US` locale (which is the locale used for translatable strings in the source code), the `LANG` environment variable should be set to the same locale. Also use shell built-ins to avoid unnecessary external command calls in `localization.sh`.
PhysicsIsAwesome
pushed a commit
to PhysicsIsAwesome/secureblue
that referenced
this pull request
Mar 1, 2026
…eblue#1924) Since `msginit` is used to generate the PO file for the `en_US` locale (which is the locale used for translatable strings in the source code), the `LANG` environment variable should be set to the same locale. Also use shell built-ins to avoid unnecessary external command calls in `localization.sh`.
PhysicsIsAwesome
pushed a commit
to PhysicsIsAwesome/secureblue
that referenced
this pull request
Mar 4, 2026
…eblue#1924) Since `msginit` is used to generate the PO file for the `en_US` locale (which is the locale used for translatable strings in the source code), the `LANG` environment variable should be set to the same locale. Also use shell built-ins to avoid unnecessary external command calls in `localization.sh`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
msginitis used to generate the PO file for theen_USlocale (which is the locale used for translatable strings in the source code), theLANGenvironment variable should be set to the same locale.Also use shell built-ins to avoid unnecessary external command calls in
localization.sh.