Skip to content

feat: remove left-over repo files from Kinoite#1822

Closed
Tiagoquix wants to merge 6 commits intosecureblue:livefrom
Tiagoquix:fedora3rd
Closed

feat: remove left-over repo files from Kinoite#1822
Tiagoquix wants to merge 6 commits intosecureblue:livefrom
Tiagoquix:fedora3rd

Conversation

@Tiagoquix
Copy link
Copy Markdown
Contributor

Improved version of #1821, which does not cause dependency issues.

Avoids a broken symlink because we delete the file.
This packages contains some files from unused repos which are already removed elsewhere in Secureblue. It is only present on the Kinoite variant.
HastD
HastD previously approved these changes Jan 21, 2026
- kdeconnectd
- fedora-chromium-config-kde
- fedora-flathub-remote
- fedora-workstation-repositories
Copy link
Copy Markdown
Collaborator

@RoyalOughtness RoyalOughtness Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this also include fedora-third-party?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out it's a dependency of plasma-discover, so we have to hold off on removing it at least until Bazaar is installed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RoyalOughtness @HastD IIRC fedora-third-party is also a dependency of other things other than plasma-discover, so this PR follows the safest path for now. The real problem is the service running in the background, which we don't want. We can decide to review the removal of fedora-third-party later when Bazaar is included, so we can be sure it doesn't affect other packages.

@RoyalOughtness
Copy link
Copy Markdown
Collaborator

we should add a pr_build target for kinoite files, since otherwise the PR builds aren't testing this

@Tiagoquix
Copy link
Copy Markdown
Contributor Author

we should add a pr_build target for kinoite files, since otherwise the PR builds aren't testing this

How can we do this? I have no clue.

@HastD
Copy link
Copy Markdown
Collaborator

HastD commented Jan 21, 2026

@RoyalOughtness It's fine, pr_build_all_main.yml is already set to run when any of the DE-specific files are modified:

on:
pull_request:
branches:
- live
- staging
paths:
- 'cosign.pub'
- 'files/scripts/**'
- 'files/system/kinoite/**'
- 'files/system/sericea/**'
- 'files/system/server/**'
- 'modules/**'
- 'recipes/**'
- '!**nvidia**'
- '!**zfs**'
- '!**.md'

@Tiagoquix Tiagoquix closed this Jan 22, 2026
@Tiagoquix
Copy link
Copy Markdown
Contributor Author

Closing in favor of #1796 (comment).

@HastD HastD mentioned this pull request Feb 1, 2026
alexvojproc added a commit to alexvojproc/secureblue that referenced this pull request Feb 1, 2026
alexvojproc added a commit to alexvojproc/secureblue that referenced this pull request Feb 1, 2026
RoyalOughtness added a commit that referenced this pull request Feb 1, 2026
* feat: preinstall libvirt/kvm/qemu (#1766)

* Install libvirt, KVM, and QEMU packages into the images at build time.
* Also install virt-manager and virt-viewer on desktop images.
* Add `ujust set-libvirt-daemons` to enable, disable, or check the status of the various libvirt daemon services and sockets. The interactive mode uses Python's inquirer module to provide an interactive checklist. These units are all preset to be disabled to avoid introducing additional attack surface for users who don't use VMs. The ujust script also disables the monolithic libvirt daemon if it was enabled.
* Remove `ujust install-libvirt-packages`.

* fix: only install virtualization packages on desktop images (#1775)

The libvirt/qemu/kvm packages increase the size of the server images by
more than we want. Also adjust the package list to avoid installing
emulators for other architectures (qemu-kvm instead of the full qemu
metapackage).

* chore: update BlueBuild CLI to v0.9.30, pass --remove-base-image (#1791)

This will free up additional disk space before rechunking.

* fix: missing arguments in ujust set-libvirt-daemons (#1792)

Need to have `*args` in the ujust signature to properly pass
command-line arguments on to the script.

* add secureblue/bazaar copr repo

* add bazaar to desktop builds

* add krunner-bazaar to kinoite builds

* remove gnome-software from silverblue builds

* remove plasma-discover on kde

* check for firmware updates and notify if available

* add blocklist

* add curated section

* remove appstream krunner

* start bazaar search provider on login

* Update utilities.just

* Update removesuid.sh

* Update removesuid.sh

* Update removesuid.sh

* Update removesuid.sh

* Update 40-secureblue.preset

* Update firmwareoutofdatenotify

* Update firmwarecheckoutofdate

* Update silverblue-modules.yml

* Update curated.yaml

* Update blocklist.yaml

* Create bazaar.te

* Create bazaar.fc

* Create bazaar.if

* don't remove dependent packages

* transition bazaar_t -> flatpak_exec_t -> flatpak_t

* mark as userns_privileged_file_type

* make firmwarecheckoutofdate more concise

* as discussed in #1822

* use flatpak_t for bazaar for now

* oepsie doepsie

---------

Co-authored-by: Daniel Hast <[email protected]>
Co-authored-by: RoyalOughtness <[email protected]>
RoyalOughtness added a commit that referenced this pull request Feb 3, 2026
* feat: preinstall libvirt/kvm/qemu (#1766)

* Install libvirt, KVM, and QEMU packages into the images at build time.
* Also install virt-manager and virt-viewer on desktop images.
* Add `ujust set-libvirt-daemons` to enable, disable, or check the status of the various libvirt daemon services and sockets. The interactive mode uses Python's inquirer module to provide an interactive checklist. These units are all preset to be disabled to avoid introducing additional attack surface for users who don't use VMs. The ujust script also disables the monolithic libvirt daemon if it was enabled.
* Remove `ujust install-libvirt-packages`.

* fix: only install virtualization packages on desktop images (#1775)

The libvirt/qemu/kvm packages increase the size of the server images by
more than we want. Also adjust the package list to avoid installing
emulators for other architectures (qemu-kvm instead of the full qemu
metapackage).

* chore: update BlueBuild CLI to v0.9.30, pass --remove-base-image (#1791)

This will free up additional disk space before rechunking.

* fix: missing arguments in ujust set-libvirt-daemons (#1792)

Need to have `*args` in the ujust signature to properly pass
command-line arguments on to the script.

* add secureblue/bazaar copr repo

* add bazaar to desktop builds

* add krunner-bazaar to kinoite builds

* remove gnome-software from silverblue builds

* remove plasma-discover on kde

* check for firmware updates and notify if available

* add blocklist

* add curated section

* remove appstream krunner

* start bazaar search provider on login

* Update utilities.just

* Update removesuid.sh

* Update removesuid.sh

* Update removesuid.sh

* Update removesuid.sh

* Update 40-secureblue.preset

* Update firmwareoutofdatenotify

* Update firmwarecheckoutofdate

* Update silverblue-modules.yml

* Update curated.yaml

* Update blocklist.yaml

* Create bazaar.te

* Create bazaar.fc

* Create bazaar.if

* don't remove dependent packages

* transition bazaar_t -> flatpak_exec_t -> flatpak_t

* mark as userns_privileged_file_type

* make firmwarecheckoutofdate more concise

* as discussed in #1822

* use flatpak_t for bazaar for now

* oepsie doepsie

---------

Co-authored-by: Daniel Hast <[email protected]>
Co-authored-by: RoyalOughtness <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants