Skip to content

fix: missing arguments in ujust set-libvirt-daemons#1792

Merged
HastD merged 1 commit intosecureblue:stagingfrom
HastD:fix-libvirt-recipe
Jan 17, 2026
Merged

fix: missing arguments in ujust set-libvirt-daemons#1792
HastD merged 1 commit intosecureblue:stagingfrom
HastD:fix-libvirt-recipe

Conversation

@HastD
Copy link
Copy Markdown
Collaborator

@HastD HastD commented Jan 16, 2026

Need to have *args in the ujust signature to properly pass command-line arguments on to the script.

Need to have `*args` in the ujust signature to properly pass
command-line arguments on to the script.
@HastD HastD requested a review from RoyalOughtness as a code owner January 16, 2026 20:03
@HastD HastD merged commit aa12e44 into secureblue:staging Jan 17, 2026
12 checks passed
@HastD HastD deleted the fix-libvirt-recipe branch January 17, 2026 01:21
HastD added a commit to HastD/secureblue that referenced this pull request Jan 18, 2026
Need to have `*args` in the ujust signature to properly pass
command-line arguments on to the script.
HastD added a commit to HastD/secureblue that referenced this pull request Jan 18, 2026
Need to have `*args` in the ujust signature to properly pass
command-line arguments on to the script.
HastD added a commit to HastD/secureblue that referenced this pull request Jan 19, 2026
Need to have `*args` in the ujust signature to properly pass
command-line arguments on to the script.
HastD added a commit that referenced this pull request Jan 19, 2026
* feat: preinstall libvirt/kvm/qemu (#1766)

* Install libvirt, KVM, and QEMU packages into the images at build time.
* Also install virt-manager and virt-viewer on desktop images.
* Add `ujust set-libvirt-daemons` to enable, disable, or check the
  status of the various libvirt daemon services and sockets. The
  interactive mode uses Python's inquirer module to provide an
  interactive checklist. These units are all preset to be disabled to
  avoid introducing additional attack surface for users who don't use
  VMs. The ujust script also disables the monolithic libvirt daemon if
  it was enabled.
* Remove `ujust install-libvirt-packages`.

* fix: only install virtualization packages on desktop images (#1775)

The libvirt/qemu/kvm packages increase the size of the server images by
more than we want. Also adjust the package list to avoid installing
emulators for other architectures (qemu-kvm instead of the full qemu
metapackage).

* chore: update BlueBuild CLI to v0.9.30, pass --remove-base-image (#1791)

This will free up additional disk space before rechunking.

* fix: missing arguments in ujust set-libvirt-daemons (#1792)

Need to have `*args` in the ujust signature to properly pass
command-line arguments on to the script.

* chore: clarify reason for commented-out capabilities
RoyalOughtness added a commit that referenced this pull request Feb 1, 2026
* feat: preinstall libvirt/kvm/qemu (#1766)

* Install libvirt, KVM, and QEMU packages into the images at build time.
* Also install virt-manager and virt-viewer on desktop images.
* Add `ujust set-libvirt-daemons` to enable, disable, or check the status of the various libvirt daemon services and sockets. The interactive mode uses Python's inquirer module to provide an interactive checklist. These units are all preset to be disabled to avoid introducing additional attack surface for users who don't use VMs. The ujust script also disables the monolithic libvirt daemon if it was enabled.
* Remove `ujust install-libvirt-packages`.

* fix: only install virtualization packages on desktop images (#1775)

The libvirt/qemu/kvm packages increase the size of the server images by
more than we want. Also adjust the package list to avoid installing
emulators for other architectures (qemu-kvm instead of the full qemu
metapackage).

* chore: update BlueBuild CLI to v0.9.30, pass --remove-base-image (#1791)

This will free up additional disk space before rechunking.

* fix: missing arguments in ujust set-libvirt-daemons (#1792)

Need to have `*args` in the ujust signature to properly pass
command-line arguments on to the script.

* add secureblue/bazaar copr repo

* add bazaar to desktop builds

* add krunner-bazaar to kinoite builds

* remove gnome-software from silverblue builds

* remove plasma-discover on kde

* check for firmware updates and notify if available

* add blocklist

* add curated section

* remove appstream krunner

* start bazaar search provider on login

* Update utilities.just

* Update removesuid.sh

* Update removesuid.sh

* Update removesuid.sh

* Update removesuid.sh

* Update 40-secureblue.preset

* Update firmwareoutofdatenotify

* Update firmwarecheckoutofdate

* Update silverblue-modules.yml

* Update curated.yaml

* Update blocklist.yaml

* Create bazaar.te

* Create bazaar.fc

* Create bazaar.if

* don't remove dependent packages

* transition bazaar_t -> flatpak_exec_t -> flatpak_t

* mark as userns_privileged_file_type

* make firmwarecheckoutofdate more concise

* as discussed in #1822

* use flatpak_t for bazaar for now

* oepsie doepsie

---------

Co-authored-by: Daniel Hast <[email protected]>
Co-authored-by: RoyalOughtness <[email protected]>
RoyalOughtness added a commit that referenced this pull request Feb 3, 2026
* feat: preinstall libvirt/kvm/qemu (#1766)

* Install libvirt, KVM, and QEMU packages into the images at build time.
* Also install virt-manager and virt-viewer on desktop images.
* Add `ujust set-libvirt-daemons` to enable, disable, or check the status of the various libvirt daemon services and sockets. The interactive mode uses Python's inquirer module to provide an interactive checklist. These units are all preset to be disabled to avoid introducing additional attack surface for users who don't use VMs. The ujust script also disables the monolithic libvirt daemon if it was enabled.
* Remove `ujust install-libvirt-packages`.

* fix: only install virtualization packages on desktop images (#1775)

The libvirt/qemu/kvm packages increase the size of the server images by
more than we want. Also adjust the package list to avoid installing
emulators for other architectures (qemu-kvm instead of the full qemu
metapackage).

* chore: update BlueBuild CLI to v0.9.30, pass --remove-base-image (#1791)

This will free up additional disk space before rechunking.

* fix: missing arguments in ujust set-libvirt-daemons (#1792)

Need to have `*args` in the ujust signature to properly pass
command-line arguments on to the script.

* add secureblue/bazaar copr repo

* add bazaar to desktop builds

* add krunner-bazaar to kinoite builds

* remove gnome-software from silverblue builds

* remove plasma-discover on kde

* check for firmware updates and notify if available

* add blocklist

* add curated section

* remove appstream krunner

* start bazaar search provider on login

* Update utilities.just

* Update removesuid.sh

* Update removesuid.sh

* Update removesuid.sh

* Update removesuid.sh

* Update 40-secureblue.preset

* Update firmwareoutofdatenotify

* Update firmwarecheckoutofdate

* Update silverblue-modules.yml

* Update curated.yaml

* Update blocklist.yaml

* Create bazaar.te

* Create bazaar.fc

* Create bazaar.if

* don't remove dependent packages

* transition bazaar_t -> flatpak_exec_t -> flatpak_t

* mark as userns_privileged_file_type

* make firmwarecheckoutofdate more concise

* as discussed in #1822

* use flatpak_t for bazaar for now

* oepsie doepsie

---------

Co-authored-by: Daniel Hast <[email protected]>
Co-authored-by: RoyalOughtness <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants