fix: make curl usage more robust#1638
Merged
RoyalOughtness merged 3 commits intosecureblue:livefrom Dec 1, 2025
Merged
Conversation
Consistently use `curl -fLsS --retry 5` in build scripts and workflows that use curl, ensuring that curl handles HTTP errors, follows redirects, retries on encountering errors that are typically temporary, and does not suppress error output in case of failure. This should make curl more robust in the presence of transient network issues and make such issues more apparent in build logs when they do occur. In the one place where curl is used in a ujust script, use a temporary file to ensure we don't end up writing partial output if curl fails.
RoyalOughtness
approved these changes
Nov 29, 2025
EsseLowNitro
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistently use
curl -fLsS --retry 5in build scripts and workflows that use curl, ensuring that curl handles HTTP errors, follows redirects, retries on encountering errors that are typically temporary, and does not suppress error output in case of failure. This should make curl more robust in the presence of transient network issues and make such issues more apparent in build logs when they do occur.In the one place where curl is used in a ujust script, use a temporary file to ensure we don't end up writing partial output if curl fails.