feat(audit): check user group memberships#1596
Merged
RoyalOughtness merged 2 commits intosecureblue:livefrom Nov 11, 2025
Merged
feat(audit): check user group memberships#1596RoyalOughtness merged 2 commits intosecureblue:livefrom
RoyalOughtness merged 2 commits intosecureblue:livefrom
Conversation
Collaborator
|
The only groups a user account would be expected to be in are their own user group, wheel if it is an administrative account, and usbguard if they use the Gnome integration. The simplest way would be to treat any unexpected groups as failures, and it also avoids falling into the badness enumeration approach. |
Membership in groups like `docker` or `libvirt` grants the user access equivalent to root. People sometimes add their main user account to these groups for convenience, possibly without being aware of the security implications. This adds a new check to the audit script that flags membership in these groups and informs the user. Additionally, the `systemd-journal` group is flagged as a warning due to allowing viewing the kernel logs, and other unrecognized groups are flagged with a generic warning about the potential security risks of group memberships. The only groups that aren't flagged are the user's username group, `wheel` (which is already checked earlier), and `usbguard`.
HastD
changed the title
RKNF404
approved these changes
Nov 10, 2025
RoyalOughtness
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Membership in groups like
dockerorlibvirtgrants the user access equivalent to root. People sometimes add their main user account to these groups for convenience, possibly without being aware of the security implications. This adds a new check to the audit script that flags membership in these groups and informs the user.Additionally, the
systemd-journalgroup is flagged as a warning due to allowing viewing the kernel logs, and other unrecognized groups are flagged with a generic warning about the potential security risks of group memberships.The only groups that aren't flagged are the user's username group,
wheel(which is already checked earlier), andusbguard.