fix: detect non-system users by presence of /var/home/$USER#1580
Merged
RoyalOughtness merged 3 commits intosecureblue:livefrom Nov 6, 2025
Merged
fix: detect non-system users by presence of /var/home/$USER#1580RoyalOughtness merged 3 commits intosecureblue:livefrom
RoyalOughtness merged 3 commits intosecureblue:livefrom
Conversation
Currently systemd user services that are only supposed to run on desktop images for real users (not system accounts) check for the existence of a `~/.config` directory to determine whether they should run. This works on typical desktop installations but can fail in circumstances where the user is created with a bare-bones home directory for whatever reason. (For example, this is the case in the integration testing environment.) Instead, we can just check for the existence of a `/var/home/$USER` directory. This seems like a more reliable indicator of whether a user account is an ordinary user as opposed to some sort of system account, and works for bare-bones home directories just as well. Signed-off-by: Daniel Hast <[email protected]>
RoyalOughtness
approved these changes
Nov 6, 2025
RKNF404
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently systemd user services that are only supposed to run on desktop images for real users (not system accounts) check for the existence of a
~/.configdirectory to determine whether they should run. This works on typical desktop installations but can fail in circumstances where the user is created with a bare-bones home directory for whatever reason. (For example, this is the case in the integration testing environment.)Instead, we can just check for the existence of a
/var/home/$USERdirectory. This seems like a more reliable indicator of whether a user account is an ordinary user as opposed to some sort of system account, and works for bare-bones home directories just as well.Fixes #1579.