fix(securedns): restrict dns-selector menu for unknown DNS#1424
Merged
RoyalOughtness merged 2 commits intosecureblue:livefrom Oct 4, 2025
Merged
fix(securedns): restrict dns-selector menu for unknown DNS#1424RoyalOughtness merged 2 commits intosecureblue:livefrom
RoyalOughtness merged 2 commits intosecureblue:livefrom
Conversation
Currently, the shortened interactive dns-selector menu (i.e. without DNSSEC etc.) is shown when systemd-resolved is in use. Since detection for VPN DNS was added (DNSResolver.UNKNOWN), this caused a bug where the extended list is mistakenly shown for VPN DNS as well. This commit shows the short menu whenever Unbound is not in use.
HastD
approved these changes
Oct 4, 2025
RoyalOughtness
approved these changes
Oct 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the shortened interactive dns-selector menu (i.e. without DNSSEC etc.) is shown when systemd-resolved is in use. Since detection for VPN DNS was added (DNSResolver.UNKNOWN), this caused a bug where the extended list is mistakenly shown for VPN DNS as well. This commit shows the short menu whenever Unbound is not in use.