feat: add an option to exit the dns-selector script#1400
Merged
RoyalOughtness merged 5 commits intosecureblue:livefrom Sep 29, 2025
ssdrive-flaktra:feat/dns-exit
Merged
feat: add an option to exit the dns-selector script#1400RoyalOughtness merged 5 commits intosecureblue:livefrom ssdrive-flaktra:feat/dns-exit
RoyalOughtness merged 5 commits intosecureblue:livefrom
ssdrive-flaktra:feat/dns-exit
Conversation
Collaborator
Author
|
I can confirm this works. |
alexvojproc
requested changes
Sep 28, 2025
Collaborator
alexvojproc
left a comment
alexvojproc
left a comment
There was a problem hiding this comment.
Fetching your branch (commit c62bc8e), your code doesn't work for me.
Collaborator
|
It seems you might have used another GPG signing key that doesn't match your GitHub account, ideally just switch it for this repo or add the email to your account. :) You're currently using 2FA8A8E4EAF8900A |
instead of setting the exit option to 0, we now just append it to the end of the list
seriously how did we not think of this?
alexvojproc
approved these changes
Sep 28, 2025
HastD
approved these changes
Sep 28, 2025
RoyalOughtness
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1399
This adds an option to the
ujust dns-selectorscript that just exits the script as requested by #1399.Draft because I'm still testing it on my machine.