fix: remove unnecessary cap from bluetooth script#1332
Merged
RoyalOughtness merged 6 commits intosecureblue:livefrom Sep 13, 2025
Merged
fix: remove unnecessary cap from bluetooth script#1332RoyalOughtness merged 6 commits intosecureblue:livefrom
RoyalOughtness merged 6 commits intosecureblue:livefrom
Conversation
Since `/etc/modprobe.d` is writable by root, `CAP_DAC_OVERRIDE` is not needed. Also fix formatting of `CapabilityBoundingSet` property and did some minor code cleanup/style changes: * Moved `SandboxedFunction` to `__init__.py`; it's few enough lines of code that there's no need for a separate submodule. * Removed unreachable code: the properties of `SandboxedFunction` of type `list[str]` cannot be `None`. * Added return type hints to all functions. * Removed unnecessary type hints from local variables. * Added shebang line to Python scripts.
Also make optional arguments keyword-only to avoid them being mixed up.
HastD
force-pushed
the
bluetooth-cap
branch
from
1ffcd9b to
61d7879
Compare
RoyalOughtness
approved these changes
Sep 12, 2025
ShadowSlayer1441
approved these changes
Sep 12, 2025
alexvojproc
pushed a commit
to alexvojproc/secureblue
that referenced
this pull request
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
/etc/modprobe.dis writable by root,CAP_DAC_OVERRIDEis not needed. Also fix formatting ofCapabilityBoundingSetproperty, improve validation of run0 options, and did some minor code cleanup/style changes:SandboxedFunctionto__init__.py; it's few enough lines of code that there's no need for a separate submodule.SandboxedFunctionso it will cause an error if non-list arguments are passed where a list is expected.SandboxedFunctionof typelist[str]cannot beNone.