fix: check bash session is interactive before modifying prompt#1299
Merged
RoyalOughtness merged 1 commit intosecureblue:livefrom Sep 1, 2025
Merged
fix: check bash session is interactive before modifying prompt#1299RoyalOughtness merged 1 commit intosecureblue:livefrom
RoyalOughtness merged 1 commit intosecureblue:livefrom
Conversation
Some scripts check whether the prompt variable `PS1` is set to determine whether the shell is interactive. While this is less robust than checking `$-`, it's still a method mentioned in the bash manual, so we should make sure not to break this behavior and only modify `PS1` if the shell is interactive. Signed-off-by: Daniel Hast <[email protected]>
|
Can confirm this fixed my login problems. |
RoyalOughtness
approved these changes
Sep 1, 2025
fiftydinar
approved these changes
Sep 1, 2025
EsseLowNitro
approved these changes
Sep 1, 2025
ShadowSlayer1441
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some scripts check whether the prompt variable
PS1is set to determine whether the shell is interactive. While this is less robust than checking$-, it's still a method mentioned in the bash manual, so we should make sure not to break this behavior and only modifyPS1if the shell is interactive.