fix: mark non-printable characters in bash prompt#1296
Merged
RoyalOughtness merged 1 commit intosecureblue:livefrom Aug 29, 2025
Merged
fix: mark non-printable characters in bash prompt#1296RoyalOughtness merged 1 commit intosecureblue:livefrom
RoyalOughtness merged 1 commit intosecureblue:livefrom
Conversation
This ensures bash correctly calculates prompt width, fixing a bug where parts of the prompt could be overwritten when navigating command history. Also switch to a simpler method of modifying the prompt that only uses `PS1` instead of `PROMPT_COMMAND`.
RKNF404
approved these changes
Aug 29, 2025
ShadowSlayer1441
approved these changes
Aug 29, 2025
RoyalOughtness
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures bash correctly calculates prompt width, fixing a bug where parts of the prompt could be overwritten when navigating command history. Also switch to a simpler method of modifying the prompt that only uses
PS1instead ofPROMPT_COMMAND. The non-printable characters are marked by enclosing them in\[\], as documented here.