Skip to content

ci: split up PR build workflow using reusable workflow#1245

Merged
RoyalOughtness merged 2 commits intosecureblue:livefrom
HastD:reusable-build-workflow
Aug 14, 2025
Merged

ci: split up PR build workflow using reusable workflow#1245
RoyalOughtness merged 2 commits intosecureblue:livefrom
HastD:reusable-build-workflow

Conversation

@HastD
Copy link
Copy Markdown
Collaborator

@HastD HastD commented Aug 12, 2025

This makes a reusable workflow out of the PR build workflow, and uses it in four workflows with different triggers:

  • pr_build_minimal.yml builds only the silverblue-main-hardened image if any non-markdown file is modified by the PR.
  • pr_build_all_main.yml builds the other four "main" (non-Nvidia, non-ZFS) images if files either specific to one of the non-Silverblue images or with more potential to affect the build process are modified.
  • pr_build_nvidia.yml builds one nvidia and one nvidia-open image if a file with "nvidia" in the filename is modified.
  • pr_build_zfs.yml builds the three ZFS images if a file with "zfs" in the filename is modified.

This should significantly reduce compute time spent unnecessarily building images for PRs that are highly unlikely to cause build failures in those images (or if they did, would cause build failures in all images, which will still be caught by pr_build_minimal.yml).

@HastD HastD requested a review from RoyalOughtness as a code owner August 12, 2025 00:16
@HastD HastD force-pushed the reusable-build-workflow branch 2 times, most recently from b3579cf to 55e04bd Compare August 12, 2025 01:44
This makes a reusable workflow out of the PR build workflow, and uses it
in four workflows with different triggers:

* `pr_build_minimal.yml` builds only the `silverblue-main-hardened`
  image if any non-markdown file is modified by the PR.
* `pr_build_all_main.yml` builds the other four "main" (non-Nvidia,
  non-ZFS images if files either specific to one of the non-Silverblue
  images or with more potential to affect the build process are
  modified.
* `pr_build_nvidia.yml` builds one `nvidia` and one `nvidia-open` image
  if a file with "nvidia" in the filename is modified.
* `pr_build_zfs.yml` builds the three ZFS images if a file with "zfs" in
  the filename is modified.

This should significantly reduce compute time spent unnecessarily
building images for PRs that are highly unlikely to cause build failures
in those images (or if they did, would cause build failures in *all*
images, which will still be caught by `pr_build_minimal.yml`).

Signed-off-by: Daniel Hast <[email protected]>
@HastD HastD force-pushed the reusable-build-workflow branch from 55e04bd to 376055d Compare August 12, 2025 16:26
@RoyalOughtness RoyalOughtness merged commit 1a346f8 into secureblue:live Aug 14, 2025
10 checks passed
@HastD HastD deleted the reusable-build-workflow branch August 14, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants