Skip to content

feat: Add German translation for the audit script#1227

Merged
RoyalOughtness merged 8 commits intosecureblue:livefrom
MatsG23:live
Aug 8, 2025
Merged

feat: Add German translation for the audit script#1227
RoyalOughtness merged 8 commits intosecureblue:livefrom
MatsG23:live

Conversation

@MatsG23
Copy link
Copy Markdown
Contributor

@MatsG23 MatsG23 commented Aug 5, 2025

Hello!

In this PR I added the German translation file for the audit script.
I tried to stay close to the original texts mostly. However, I changed the style of the audit test texts a bit in German.
For example, Checking for hardened kernel parameters became Kernel parameters hardened. I chose this Boolean-style way to not make the sentences too complicated.

Here are some specific lines I am unsure about:

  • L361 - what is inserted there?
  • L749 to L771 - not sure how the partial sentences are inserted in the final texts
  • L770 - I translated "flagged" more like "marked (permissions)". There might be a better translation.

Feel free to provide feedback. It would be nice to have another German-speaking person look over this.

@MatsG23 MatsG23 requested a review from RoyalOughtness as a code owner August 5, 2025 18:10
@HastD
Copy link
Copy Markdown
Collaborator

HastD commented Aug 5, 2025

Thanks for this! To address your questions:

  • L361: This is referring to file permission modes, so for example the output might be something like "/etc/ld.so.preload has mode 644 (expected 600)". (The {1:o} format specifiers are to print the number in octal.) In particular, the first placeholder will be filled in with a file path, while the other two will be filled in with numbers.
  • L749-771: These are actually complete sentences, just written in a somewhat concise style. These are the status descriptions printed as part of the help text when you run ujust audit-secureblue --help; they describe what the statuses [FAIL], [WARN], [INFO], and [PASS] each mean for a flatpak app.
  • L770: Yes, "marked" sounds reasonable—the intended meaning is essentially "brought to the user's attention".

@MatsG23
Copy link
Copy Markdown
Contributor Author

MatsG23 commented Aug 5, 2025

Okay, it should be fine then.

Copy link
Copy Markdown
Collaborator

@pxlkng pxlkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to stay close to the original texts mostly. However, I changed the style of the audit test texts a bit in German.
For example, Checking for hardened kernel parameters became Kernel parameters hardened. I chose this Boolean-style way to not make the sentences too complicated.

I don't think this is a good idea or necessary.
We shouldn't change the meaning of the sentence if possible. The sentences indicate that something is being checked, a process. Therefore we should also convey this in the German translation. The way you currently translated this changes the meaning drastically, it now describes the state of something, example:

Kernel-Parameter [sind] gehärtet (Zustand, kein Prozess)
(eng. kernel arguments [are] hardened)

While this can be understood with the indicator of PASSED, FAILED, etc being on the right hand side for each of those lines, it imo unnecessarily changes the meaning and can potentially lead to users interpreting those sentences "as-is" and think that the above example actually means "Das Ergebnis ist, dass die Kernel-Parameter gehärtet sind" (eng. the result is that the kernel arguments are hardened), overlooking the FAILED on the right.

I have made some suggestions, improvements and corrections below.
I also provided an, in my opinion, much better way to translate those "checking" sentences. Its still not an exact translation because I agree that one-to-one translating them would be overly complex:
Ensuring no sysctl overrides -> Stelle Sicher, dass es keine sysctl Überschreibungen gibt (example for what would be exact one-to-one translation)
But, it still conveys the process of "checking" something, which I think is important.

@pxlkng
Copy link
Copy Markdown
Collaborator

pxlkng commented Aug 5, 2025

Also to note, I did not check the syntax of the translation file format for errors or that all strings have translations present.

@MatsG23
Copy link
Copy Markdown
Contributor Author

MatsG23 commented Aug 6, 2025

I initially thought, there was no good way to translate the "ensuring"/"checking" sentences. But I agree that changing the meaning to describe the state poses the risk to overlook the status indicator.
I will apply the suggestions and double-check.

@MatsG23
Copy link
Copy Markdown
Contributor Author

MatsG23 commented Aug 6, 2025

Additionally, I added proper articles and sentence beginnings in L763, L773, L783 and L788 because we agreed earlier that omitting articles is more colloquial

Copy link
Copy Markdown
Collaborator

@pxlkng pxlkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more nitpicks and one oversight I noticed in my second review.

Otherwise, I'm happy with all translations/changes and for my part would approve this PR.

Thank you very much for your work.

Signed-off-by: MatsG23 <[email protected]>
@pxlkng
Copy link
Copy Markdown
Collaborator

pxlkng commented Aug 6, 2025

Oh, you also still need a conventional commits PR title.

@MatsG23 MatsG23 changed the title Add German translation for the audit script feat: Add German translation for the audit script Aug 6, 2025
@RoyalOughtness RoyalOughtness enabled auto-merge (squash) August 8, 2025 17:54
@RoyalOughtness RoyalOughtness merged commit 97f0381 into secureblue:live Aug 8, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants