feat: Add German translation for the audit script#1227
feat: Add German translation for the audit script#1227RoyalOughtness merged 8 commits intosecureblue:livefrom
Conversation
Signed-off-by: MatsG23 <[email protected]>
Signed-off-by: MatsG23 <[email protected]>
|
Thanks for this! To address your questions:
|
Signed-off-by: MatsG23 <[email protected]>
|
Okay, it should be fine then. |
There was a problem hiding this comment.
I tried to stay close to the original texts mostly. However, I changed the style of the audit test texts a bit in German.
For example, Checking for hardened kernel parameters became Kernel parameters hardened. I chose this Boolean-style way to not make the sentences too complicated.
I don't think this is a good idea or necessary.
We shouldn't change the meaning of the sentence if possible. The sentences indicate that something is being checked, a process. Therefore we should also convey this in the German translation. The way you currently translated this changes the meaning drastically, it now describes the state of something, example:
Kernel-Parameter [sind] gehärtet (Zustand, kein Prozess)
(eng. kernel arguments [are] hardened)
While this can be understood with the indicator of PASSED, FAILED, etc being on the right hand side for each of those lines, it imo unnecessarily changes the meaning and can potentially lead to users interpreting those sentences "as-is" and think that the above example actually means "Das Ergebnis ist, dass die Kernel-Parameter gehärtet sind" (eng. the result is that the kernel arguments are hardened), overlooking the FAILED on the right.
I have made some suggestions, improvements and corrections below.
I also provided an, in my opinion, much better way to translate those "checking" sentences. Its still not an exact translation because I agree that one-to-one translating them would be overly complex:
Ensuring no sysctl overrides -> Stelle Sicher, dass es keine sysctl Überschreibungen gibt (example for what would be exact one-to-one translation)
But, it still conveys the process of "checking" something, which I think is important.
|
Also to note, I did not check the syntax of the translation file format for errors or that all strings have translations present. |
|
I initially thought, there was no good way to translate the "ensuring"/"checking" sentences. But I agree that changing the meaning to describe the state poses the risk to overlook the status indicator. |
Signed-off-by: MatsG23 <[email protected]>
|
Additionally, I added proper articles and sentence beginnings in L763, L773, L783 and L788 because we agreed earlier that omitting articles is more colloquial |
Signed-off-by: MatsG23 <[email protected]>
pxlkng
left a comment
There was a problem hiding this comment.
Two more nitpicks and one oversight I noticed in my second review.
Otherwise, I'm happy with all translations/changes and for my part would approve this PR.
Thank you very much for your work.
Signed-off-by: MatsG23 <[email protected]>
|
Oh, you also still need a conventional commits PR title. |
Hello!
In this PR I added the German translation file for the audit script.
I tried to stay close to the original texts mostly. However, I changed the style of the audit test texts a bit in German.
For example,
Checking for hardened kernel parametersbecameKernel parameters hardened. I chose this Boolean-style way to not make the sentences too complicated.Here are some specific lines I am unsure about:
Feel free to provide feedback. It would be nice to have another German-speaking person look over this.