fix: sandbox sed commands, style/clarity improvements#1208
Merged
RoyalOughtness merged 1 commit intosecureblue:livefrom Jul 28, 2025
Merged
fix: sandbox sed commands, style/clarity improvements#1208RoyalOughtness merged 1 commit intosecureblue:livefrom
RoyalOughtness merged 1 commit intosecureblue:livefrom
Conversation
The GNU sed program is capable of reading and writing files and executing external programs. To eliminate the possibility of command injection, any sed usage where the script to be run has variable substitutions should use the `--sandbox` option to ensure scripts attempting to use the e/w/r commands are rejected. Also made some conciseness/style/clarity improvements to various sed scripts. Signed-off-by: Daniel Hast <[email protected]>
RoyalOughtness
approved these changes
Jul 25, 2025
RKNF404
approved these changes
Jul 28, 2025
RoyalOughtness
pushed a commit
to RoyalOughtness/secureblue-dev
that referenced
this pull request
Aug 4, 2025
The GNU sed program is capable of reading and writing files and executing external programs. To eliminate the possibility of command injection, any sed usage where the script to be run has variable substitutions should use the `--sandbox` option to ensure scripts attempting to use the e/w/r commands are rejected. Also made some conciseness/style/clarity improvements to various sed scripts. Signed-off-by: Daniel Hast <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GNU sed program is capable of reading and writing files via the r/w commands and executing external programs via the e command. To eliminate the possibility of command injection, any sed usage where the script to be run has variable substitutions should use the
--sandboxoption to ensure scripts attempting to use the e/w/r commands are rejected.Also made some conciseness/style/clarity improvements to various sed scripts.