fix: deny userns creation for userdomain, not just unconfined_t#1204
Merged
RoyalOughtness merged 2 commits intosecureblue:livefrom Jul 30, 2025
Merged
fix: deny userns creation for userdomain, not just unconfined_t#1204RoyalOughtness merged 2 commits intosecureblue:livefrom
RoyalOughtness merged 2 commits intosecureblue:livefrom
Conversation
The `userdomain` attribute includes not just `unconfined_t` but also `user_t`, `staff_t`, `sysadm_t`, etc so the restrictions on user namespace creation also apply to confined users. Signed-off-by: Daniel Hast <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
files/scripts/selinux/user_namespace/userns_deny_unconfined_relabels.cil
Show resolved
Hide resolved
RoyalOughtness
approved these changes
Jul 28, 2025
WavyEbuilder
approved these changes
Jul 29, 2025
RoyalOughtness
pushed a commit
to RoyalOughtness/secureblue-dev
that referenced
this pull request
Aug 4, 2025
…reblue#1204) * fix: deny userns creation for userdomain, not just unconfined_t The `userdomain` attribute includes not just `unconfined_t` but also `user_t`, `staff_t`, `sysadm_t`, etc so the restrictions on user namespace creation also apply to confined users. Signed-off-by: Daniel Hast <[email protected]> * refactor: use attributes to simplify relabel deny rules --------- Signed-off-by: Daniel Hast <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
userdomainattribute includes not justunconfined_tbut alsouser_t,staff_t,sysadm_t, etc so the restrictions on user namespace creation also apply to confined users.Also simplify the relabeling deny rules using attributes.