feat: Warn user of exited (failed) service when running ujust audit-secureblue#1184
Merged
RoyalOughtness merged 9 commits intolivefrom Jul 21, 2025
unknown repository
Merged
feat: Warn user of exited (failed) service when running ujust audit-secureblue#1184RoyalOughtness merged 9 commits intolivefrom unknown repository
ujust audit-secureblue#1184RoyalOughtness merged 9 commits intolivefrom
unknown repository
Conversation
added 2 commits
July 16, 2025 22:07
Detect if a service has failed in addition to detecting whether it has been enabled. If the service has failed, warn the user about the failure instead of passing the audit.
ghost
requested a review
from 
ghost
changed the title
ujust audit-secureblueujust audit-secureblue
ghost
changed the title
ujust audit-secureblueujust audit-secureblue
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ghost
changed the title
ujust audit-secureblueujust audit-secureblue
HastD
approved these changes
Jul 17, 2025
HastD
approved these changes
Jul 19, 2025
RoyalOughtness
previously approved these changes
Jul 19, 2025
Collaborator
|
@josh3kd couple linter errors, otherwise this looks good |
Collaborator
|
Looks like it's just flagging some minor formatting issues. Running |
RoyalOughtness
approved these changes
Jul 20, 2025
HastD
approved these changes
Jul 20, 2025
Collaborator
|
@josh3kd I'm unable to merge from live because you didn't grant me the permission 😅 |
Author
|
@RoyalOughtness Oops, fixed now. Sorry |
RoyalOughtness
pushed a commit
to RoyalOughtness/secureblue-dev
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ujust audit-secureblueis ran, detect if a system service had exited with failure. If the service had failed, downgrade the status of the audit from PASS to WARN to alert the user.