feat(audit): special-case Flatseal and Warehouse permission checks#1101
Merged
RoyalOughtness merged 3 commits intosecureblue:livefrom Jun 4, 2025
Merged
feat(audit): special-case Flatseal and Warehouse permission checks#1101RoyalOughtness merged 3 commits intosecureblue:livefrom
RoyalOughtness merged 3 commits intosecureblue:livefrom
Conversation
This makes Flatseal and Warehouse display as `NOTE` rather than `FAIL` in the flatpak permission audit, because they are installed by default and require the ability to manage flatpaks for their functionality. The accompanying text notes this, and the recommendations to remove those permissions (which would break Flatseal and Warehouse) are suppressed. Also fixed a small formatting bug in how padding width was calculated and how multi-line warnings are displayed. Signed-off-by: Daniel Hast <[email protected]>
RoyalOughtness
approved these changes
Jun 3, 2025
EsseLowNitro
approved these changes
Jun 3, 2025
RoyalOughtness
pushed a commit
to RoyalOughtness/secureblue-dev
that referenced
this pull request
Aug 4, 2025
…ecureblue#1101) This makes Flatseal and Warehouse display as `NOTE` rather than `FAIL` in the flatpak permission audit, because they are installed by default and require the ability to manage flatpaks for their functionality. The accompanying text notes this, and the recommendations to remove those permissions (which would break Flatseal and Warehouse) are suppressed. Also fixed a small formatting bug in how padding width was calculated and how multi-line warnings are displayed. Signed-off-by: Daniel Hast <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes Flatseal and Warehouse display as
NOTErather thanFAILin the flatpak permission audit, because they are installed by default and require the ability to manage flatpaks for their functionality.The accompanying text notes this, and the recommendations to remove those permissions (which would break Flatseal and Warehouse) are suppressed.
Also fixed a small formatting bug in how padding width was calculated and how multi-line warnings are displayed.