fix(audit): only check permissions of flatpak apps, not runtimes#1071
Merged
RoyalOughtness merged 3 commits intosecureblue:livefrom May 29, 2025
Merged
fix(audit): only check permissions of flatpak apps, not runtimes#1071RoyalOughtness merged 3 commits intosecureblue:livefrom
RoyalOughtness merged 3 commits intosecureblue:livefrom
Conversation
Flatpak overrides on runtimes don't appear to impact the actual permissions of flatpak apps using that runtime, so there's no point in checking them. The behavior of the flatpak sandbox is determined by the permissions on the app itself, which are already checked. Signed-off-by: Daniel Hast <[email protected]>
For example this happens if the output is piped to another program.
RoyalOughtness
approved these changes
May 26, 2025
Rubiginosa
approved these changes
May 29, 2025
ShadowSlayer1441
approved these changes
May 29, 2025
RoyalOughtness
pushed a commit
to RoyalOughtness/secureblue-dev
that referenced
this pull request
Aug 4, 2025
…ureblue#1071) * fix(audit): only check permissions of flatpak apps, not runtimes Flatpak overrides on runtimes don't appear to impact the actual permissions of flatpak apps using that runtime, so there's no point in checking them. The behavior of the flatpak sandbox is determined by the permissions on the app itself, which are already checked. Signed-off-by: Daniel Hast <[email protected]> * fix: default to width 80 if can't get terminal width For example this happens if the output is piped to another program. --------- Signed-off-by: Daniel Hast <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flatpak overrides on runtimes aren't meaningful and don't impact the actual permissions of flatpak apps using that runtime, so there's no point in checking them. The behavior of the flatpak sandbox is determined by the permissions on the app itself, which are already checked.
This reduces visual clutter in the audit script as there are no longer a bunch of lines for flatpak runtimes with no useful info, and also makes the script faster (since querying flatpak permissions is the performance bottleneck).
I also fixed a bug where the audit script would crash if piped to another program (because it'd try and fail to get the terminal width).