fix(audit): handle errors better; add rec for ld.so.preload check.#1034
Merged
RoyalOughtness merged 2 commits intosecureblue:livefrom May 7, 2025
Merged
fix(audit): handle errors better; add rec for ld.so.preload check.#1034RoyalOughtness merged 2 commits intosecureblue:livefrom
RoyalOughtness merged 2 commits intosecureblue:livefrom
Conversation
Signed-off-by: Daniel Hast <[email protected]>
Other python3 installations (such as via brew) can run into problems in some circumstances, such as not being able to access certain modules installed as RPM packages. Signed-off-by: Daniel Hast <[email protected]>
RoyalOughtness
approved these changes
May 7, 2025
ShadowSlayer1441
approved these changes
May 7, 2025
RoyalOughtness
pushed a commit
to RoyalOughtness/secureblue-dev
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds fallback error handling to the audit script so that an exception in one check doesn't cause the whole script to terminate early. Instead, the traceback is printed to stderr in place and the script then continues with the rest of the checks. This means that a bug in one check won't render the whole script unusable, but it will still be clearly visible as an unexpected error.
I also added a recommendation to the
/etc/ld.so.preloadcheck, and modified the shebang andaudit.justto always use the system Python installation at/usr/bin/python3.