signer: _from/_to_dict helpers for Key base fields#558
Merged
lukpueh merged 1 commit intosecure-systems-lab:mainfrom Apr 14, 2023
Merged
signer: _from/_to_dict helpers for Key base fields#558lukpueh merged 1 commit intosecure-systems-lab:mainfrom
lukpueh merged 1 commit intosecure-systems-lab:mainfrom
Conversation
Add de/serialization helpers for common fields in the Key base class, which may be used in subclass from/to_dict methods for convenience. * _to_dict: This could be Key.to_dict, which subclasses default to, but we prefer that subclasses must implement a to_dict, to avoid unnoticed serialization errors. * _from_dict: Other than from_dict, this one does not create a Key instance, but just returns the popped off fields. This makes usage in subclasses more flexible and less mystical. Signed-off-by: Lukas Puehringer <[email protected]>
jku
approved these changes
Apr 12, 2023
Collaborator
jku
left a comment
jku
left a comment
There was a problem hiding this comment.
Method naming is a bit suspicious maybe... but I've tried to come up with better suggestions for a week and came up with nothing so LGTM.
Member
Author
In the TUF metadata API we call these |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add de/serialization helpers for common fields in the Key base class, which may be used in subclass from/to_dict methods for convenience.
_to_dict: This could be Key.to_dict, which subclasses default to, but we prefer that subclasses must implement a to_dict, to avoid unnoticed serialization errors.
_from_dict: Other than from_dict, this one does not create a Key instance, but just returns the popped off fields. This makes usage in subclasses more flexible and less mystical (lessons learned from theupdateframework/python-tuf@ace25e4).