Drop md5 and sha1 schemes from supported key schemes#554
Merged
lukpueh merged 1 commit intosecure-systems-lab:mainfrom Apr 11, 2023
Merged
Drop md5 and sha1 schemes from supported key schemes#554lukpueh merged 1 commit intosecure-systems-lab:mainfrom
lukpueh merged 1 commit intosecure-systems-lab:mainfrom
Conversation
Collaborator
|
Quick comment:
This is probably still fine: nobody should be using these hash algorithms in the year 2023 (the theoretical danger is that existing keys used somewhere could stop working because of this... but I do think it's theoretical) @lukpueh opinions? |
Collaborator
|
Also, please have a look at the lint results (you can check them locally too with |
Member
Agreed. IMO annoying potential users of md5, sha1 is a fair risk for us to take. |
Related to secure-systems-lab#512, no changes to keys/ module.
ckilcoin
force-pushed
the
remove-old-schemes
branch
from
52aa4b7 to
b9306a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #512
Drop md5 and sha1 schemes from supported key schemes without changing keys/ module.
Please verify and check that the pull request fulfils the following requirements:
Tested by running tox -e py311, no additional tests needed since it is a removal of schemes.