Remove shebang line from hash.py #498#544
Merged
mnm678 merged 1 commit intosecure-systems-lab:mainfrom Mar 21, 2023
Merged
Conversation
Python2 support has been dropped and we do not need to run the module by itself.
adityasaky
approved these changes
Mar 21, 2023
Member
adityasaky
left a comment
adityasaky
left a comment
There was a problem hiding this comment.
LGTM, thanks @ckilcoin! Do you want to pick up the bonus task of assessing other shebang occurrences in the package as well?
mnm678
approved these changes
Mar 21, 2023
Author
|
Sure, I'll remove what I can and submit a second PR. |
ckilcoin
pushed a commit
to ckilcoin/securesystemslib
that referenced
this pull request
Mar 21, 2023
Followup from work in secure-systems-lab#544 and secure-systems-lab#498 Other instances are in diff files, actual generated python code, or unrelated to python shebang instances
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #498
Remove shebang line from hash.py
Python2 support has been dropped and we do not need to run the module by itself.