Remove securesystemslib.process module#505
Merged
lukpueh merged 1 commit intosecure-systems-lab:masterfrom Feb 16, 2023
Merged
Conversation
This module was originally developed in in-toto and transferred to securesystemslib in secure-systems-lab#174, primarily as Py2/Py3-agnostic wrapper around stdlib's `subprocess.run`, to run the `gpg` command. In secure-systems-lab#502 we switched to using `subprocess.run` directly. Another wrapper around `subprocess.run`, provided by the module, allows capturing standard streams AND write them to a terminal. It was developed as specific `in-toto-run` feature and does not need to be public API in sslib. in-toto/in-toto#544 moves the function back to in-toto. closes secure-systems-lab#345, transfers secure-systems-lab#337 (to in-toto) Signed-off-by: Lukas Puehringer <[email protected]>
Member
Author
adityasaky
approved these changes
Feb 13, 2023
Member
adityasaky
left a comment
adityasaky
left a comment
There was a problem hiding this comment.
Approving on behalf of in-toto/in-toto.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a BREAKING CHANGE for in-toto, must coordinate release! (cc in-toto/in-toto#544)
This module was originally developed in in-toto and transferred to securesystemslib in #174, primarily as Py2/Py3-agnostic wrapper around stdlib's
subprocess.run, to run thegpgcommand. In #502 we switched to usingsubprocess.rundirectly.Another wrapper around
subprocess.run, provided by the module, allows capturing standard streams AND write them to a terminal. It was developed as specificin-toto-runfeature and does not need to be public API in sslib. in-toto/in-toto#544 moves the function back to in-toto.closes #345,
transfers #337 (to in-toto)