Update Linux media handling - #1146
Merged
marchcat merged 29 commits intoApr 9, 2024
Merged
Conversation
We need libpulse-dev for volume_catcher Linux
…eds to be rebuilt and we do not have a fresh one from LL yet. Forcefully undefine LIB_NDOF, it gets defined in the build variables no matter if it is safe to define.
…ng to install 32 bit compat packages makes no sense at all
Open
Contributor
Author
|
Builds passed. From my side this is good to go |
At least now it is peculiar shared magic with only one implementation.
…etermine this by reading "/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq". Only if this fails go back to /proc/cpuinfo
…flags are for which OS/compiler
marchcat
approved these changes
Apr 9, 2024
marchcat
left a comment
marchcat
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution.
This looks fine to me and builds successfully.
Contributor
|
@callumlinden, what do you think? |
Contributor
callumlinden
approved these changes
Apr 9, 2024
callumlinden
left a comment
callumlinden
left a comment
Contributor
There was a problem hiding this comment.
Since most of the changes are Linux specific, I wasn't able to offer much in the way of insight but at a high level at least, looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will: