Conversation
glaubitz
changed the title
|
I had to add to add the three syscalls |
glaubitz
force-pushed
the
m68k
branch
3 times, most recently
from
9382c86 to
cb716ff
Compare
glaubitz
changed the title
|
Thanks so much for the pull request, @glaubitz. Let us know when m68k support has been merged into the kernel, and I'll take a deeper look. 👍 |
|
Hi @glaubitz, a quick question for you: are there any modern, common Linux distros which support m68k? |
|
On Feb 6, 2023, at 11:36 PM, Paul Moore ***@***.***> wrote:
Hi @glaubitz, a quick question for you: are there any modern, common Linux distros which support m68k?
Yes, Debian and Gentoo.The port is very actively maintained and has a vibrant hobbyist around it with even new hardware being developed such as the Pi-Storm and Apollo accelerator cards for the Amiga.
|
|
Great, thanks! |
|
seccomp support for m68k was just merged today into Linus' tree: |
|
@glaubitz, looks like we can now review these changes and start to work on getting them into libseccomp. Correct? If so, would you mind updating your patchset to resolve the conflicts. (m86k collided with LoongArch, but the collisions look fairly trivial.) Once you do that, I'll look over the code. Thanks so much! |
Yes.
Rebase should be done now. |
|
On Mar 31, 2023, at 9:52 PM, Paul Moore ***@***.***> wrote:
@pcmoore requested changes on this pull request.
In include/seccomp-syscalls.h:
@@ -824,6 +839,12 @@
#define __SNR_getitimer __NR_getitimer
+#ifdef __NR_atomic_getpagesize
+#define __SNR_getpagesize __NR_getpagesize
+#else
+#define __SNR_getpagesize __PNR_getpagesize
I would have expected the above code to look like this:
#ifdef __NR_atomic_getpagesize
#define __SNR_atomic_getpagesize __NR_atomic_getpagesize
#else
#define __SNR_atomic_getpagesize __PNR_atomic_getpagesize
... is this a typo or is there some m68k cleverness going on here?
It’s a typo. Will fix that in a bit. Thanks a lot for catching this.
|
pcmoore
left a comment
pcmoore
left a comment
There was a problem hiding this comment.
Looks good to me.
Acked-by: Paul Moore <[email protected]>
|
Linux 6.3 which includes seccomp support for m68k was just released today ;-). |
Congrats! I have carved out time this week to review the changes. Thanks for your patience, @glaubitz |
drakenclimber
left a comment
drakenclimber
left a comment
There was a problem hiding this comment.
I found a silly nitpick, @glaubitz, but the patchset looks good to me. Thanks for all your hard work and patience.
Acked-by: Tom Hromatka <[email protected]>
Signed-off-by: John Paul Adrian Glaubitz <[email protected]>
Signed-off-by: John Paul Adrian Glaubitz <[email protected]>
4 participants
This pull request adds support for the Motorola 68000 architecture to libseccomp.
Patches for seccomp support in the kernel have been posted on the LKML [1] but not merged
yet. Plus, libseccomp currently fails to build from source after the
syscall.csvfile has beenupdated to include the syscalls for m68k. The problem seem to be a number of syscalls which
exist exclusively on m68k.
For this reason, I'm marking this pull request as WIP.