Repository navigation
BUG: fix ownership, delay Py_SET_TYPE until the end - #53
Merged
Merged
Conversation
Owner
|
Thanks, sorry, I rushed through the fixes yesterday and I think I missed that (I may have thought that "stealing" the singleton is fine due to interned, but that is silly). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the ownership issues I was describing, along with a
castingimplleak.Delaying Py_SET_TYPE until the very end avoids needing to roll back the change in the error paths, which technically needs to happen. I also added a comment to explain the ownership semantics.