You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Finish reorganization of "dtype transfer" casting code with new dtypes #9
This function already uses the new code largely, but the input and/or output can be misaligned or byte swapped. In that case casting_impl->get_transferfunction is allowed to pass back dtypes that that are different from the input dtypes.
This means that multiple "casts" are needed (for alignment it is always needed in that sense):
Do input cast input_dtype -> "input_dtype_returned_by casting_impl->get_transferfunction" (normally this should be byte swapping)
Do the actual cast.
Do output cast "output_dtype_returned_by casting_impl->get_transferfunction" -> output_dtype.
Another example I could imagine/allow: float -> string cast always returns S32, so the string might need to be shortened or zero padded.
The current machinery uses the NPY_AUXDATA, etc. to already implement chaining when necessary, the new should actually be simpler, because 3 steps are always enough.
Right now I have the get_transferfunction signature on the DTypes, which is modelled after the existing function. Both are private API, so they can be changed.
Activity
Merge pull request #9 from hameerabbasi/uarray-me
Add 64 bit Windows builds [wheel build]
mattip commentedon Jul 27, 2023
Going through old issues, I think we can close this, right?