You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Continue refactoring and maintenance of new array coercion. #8
@mattip if you have time, maybe you can look at the refactor of array coersion (param detection + filling new array). All of this likely needs some refactor.
Is the central function which finds the shape and dtype right now. It calls the main function for finding the right DType (only the class, not the actual dtype, e.g. string length!):
If the input is string (or another "flexible" dtype) a second pass will be done to figure out the string length. There is some annoying thing around promotion, since np.array(big_endian_float64_arr) actually preserves the endianess.
Currently it used mainly through PyArray_GetArrayParamsFromObject (except for the ufunc code). The actually filling then is done by setArrayFromSequence, however, if we leave that cache design to store converted __array__ objects, then we need to replace it with a simpler version using the coercion cache.
There are probably many confusing details here, so lets talk if you look at it and get stuck.
Activity
mattip commentedon Nov 20, 2019
This is on the dtypemeta branch
Add 64 bit Windows builds [wheel build]
Merge pull request #8 from andyfaff/macwheel
mattip commentedon Jul 27, 2023
Going through my old issues, I think we can close this right?