Skip to content

Commit b6c64c8

Browse files
committed
[fix](be) Update row binlog LSN test call
### What problem does this PR solve? Issue Number: close apache#65418 Related PR: apache#65076 Problem Summary: The row-binlog partial-update BE unit test still passed a pointer to a shared vector after allocate_binlog_lsn changed to accept a vector reference. Initialize the shared vector and pass the referenced vector so the test compiles with the current API. ### Release note None ### Check List (For Author) - Test: Not run (remote BE compilation and unit test follow this commit) - Behavior changed: No - Does this need documentation: No
1 parent 3940f65 commit b6c64c8

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎be/test/olap/rowset/group_rowset_writer_test.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,8 +298,8 @@ TEST_F(GroupRowsetWriterTest, partialUpdateSkipsHiddenNonKeyColumns) {
298298

299299
auto lsn_buffer = AutoIncIDBuffer::create_shared(1, 1, kBinlogLsnAutoIncId);
300300
lsn_buffer->append_range_for_test(1000, 1);
301-
std::shared_ptr<std::vector<int64_t>> lsn_ids;
302-
ASSERT_TRUE(allocate_binlog_lsn(lsn_buffer, 1, &lsn_ids).ok());
301+
auto lsn_ids = std::make_shared<std::vector<int64_t>>();
302+
ASSERT_TRUE(allocate_binlog_lsn(lsn_buffer, 1, *lsn_ids).ok());
303303
binlog_options.insert_seg_lsn(0, lsn_ids);
304304

305305
auto row_binlog_writer_res = _tablet->create_rowset_writer(row_binlog_context, false);

0 commit comments

Comments
 (0)