This repository was archived by the owner on Mar 19, 2026. It is now read-only.
Repository navigation
Commit 8d87464
committed
Make populate method optional
I know, I know. It's weird to have the populate() method in a
PopulationService be optional. HOWEVER! there are a number of tables
that we're populating through other services (e.g., meetings, course
instances) and we may need to split those out into separate drop()
functions so we can prevent deadlocks.
Apparently there isn't a way to define an optional abstract method in an
abstract class, but if we drop the abstract keyword from the method we
can make it optional and it will still enforce the type rules on
parameters and return values.
See: microsoft/TypeScript#64131 parent 6125481 commit 8d87464
1 file changed
Lines changed: 3 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
8 | | - | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | | - | |
22 | | - | |
| 20 | + | |
23 | 21 | | |
24 | 22 | | |
25 | 23 | | |
| |||
0 commit comments