add ability to create a client with own tls connector#606
Closed
seanmonstar wants to merge 1 commit into0.9.xfrom
Closed
add ability to create a client with own tls connector#606seanmonstar wants to merge 1 commit into0.9.xfrom
seanmonstar wants to merge 1 commit into0.9.xfrom
Conversation
|
LGTM @Goirad can you review? |
|
Also looks good to me |
Contributor
|
is this blocked on anything (other than resolving the conflicts)? I'd like to use this feature as soon as its available. |
Owner
Author
|
@nicklan I believe I mostly just forgot about this. After a rebase, this could probably merge. I have the slightest inner feeling that it's not the best solution, but don't have a better suggestion, so 🤷♂ . |
Contributor
|
Okay cool. I agree it's not super elegant, but I think it's better than maintaining your own api to abstract over all possible backends. |
Contributor
|
I rebased this and made a new PR at #809. Would be great if it could get merged :) |
Owner
Author
|
Merged via #809. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapts #562. Instead of the builder method returning a
bool, thebuildcall will return an error if it didn't understand theAnyvalue.