Repository navigation
Fix encoding of process output under windows - #766
Merged
Merged
Conversation
Output of commands under windows is not UTF-8 by default, this can lead to "invalid byte sequence in UTF-8" error on sylink check
Owner
|
Thanks for the pull request, @rymut. This currently breaks a large number of tests when running on Linux (which is what the vast majority of Overcommit users use). If the issue is only reproducible when checking for bad symlinks, can we isolate this change to just change the encoding on the problematic line? Specifically: |
Contributor
Author
|
Thanks @sds: in my case only calling win32_symlink is reproducible - but the underlying problem will still be present. |
sds
approved these changes
Nov 3, 2021
sds
left a comment
Owner
There was a problem hiding this comment.
Thank you for making the changes. Tests pass locally for me on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output of commands under windows is not UTF-8 by default, this
can lead to "invalid byte sequence in UTF-8" error on symlink check