Skip to content

Unstaged changes lost when pre-commit plugin modified #129

Closed

Description

@seanpclark

During a commit I received the message "The following pre-commit plugins have been added, changed, or..." since a plugin had been modified. At that point (before running overcommit --sign pre-commit), I checked git status and noticed unstaged items were lost.

Activity

  1. changed the title [-]Unstaged changes lost when pre-commit plugin has been modified[/-] [+]Unstaged changes lost when pre-commit plugin modified[/+] on Mar 11, 2015
  2. sds commented on Mar 11, 2015

    @sds
    Owner

    Hey @seanpclark,

    Are you sure they aren't in your stash? While this is a bug (we should properly restore the stash if the plugin signature validation fails), I believe we always stash changes so that they are never lost.

    git stash list
    
  3. seanpclark commented on Mar 11, 2015

    @seanpclark
    Author

    @sds You're totally correct... it was stashed and I didn't think to check. Restoring stash would resolve the issue.

  4. added a commit that references this issue on Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions