Skip to content

Commit ce3e508

Browse files
committed
Finalize three-shard CI with one aggregate required check
1 parent e372511 commit ce3e508

2 files changed

Lines changed: 9 additions & 14 deletions

File tree

‎.github/workflows/tests.yml‎

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Tests
22
on:
33
push:
4-
branches: [main, ci/shard-tests]
4+
branches: [main]
55
pull_request:
66
branches: [main]
77

@@ -59,17 +59,6 @@ jobs:
5959
flag-name: ruby${{ matrix.ruby-version }}-${{ matrix.os }}-shard${{ strategy.job-index }}
6060
parallel: true
6161

62-
finish:
63-
needs: rspec
64-
runs-on: ubuntu-latest
65-
66-
steps:
67-
- name: Finalize code coverage report
68-
uses: coverallsapp/github-action@v2
69-
with:
70-
github-token: ${{ secrets.github_token }}
71-
parallel-finished: true
72-
7362
overcommit:
7463
timeout-minutes: 10
7564
runs-on: ubuntu-latest
@@ -96,7 +85,7 @@ jobs:
9685
ci:
9786
name: CI
9887
if: ${{ always() }}
99-
needs: [rspec, overcommit, finish]
88+
needs: [rspec, overcommit]
10089
runs-on: ubuntu-latest
10190
timeout-minutes: 2
10291

@@ -105,3 +94,9 @@ jobs:
10594
env:
10695
JOB_RESULTS: ${{ toJSON(needs) }}
10796
run: echo "$JOB_RESULTS" | jq -e 'all(.[]; .result == "success")'
97+
98+
- name: Finalize code coverage report
99+
uses: coverallsapp/github-action@v2
100+
with:
101+
github-token: ${{ secrets.github_token }}
102+
parallel-finished: true

‎CONTRIBUTING.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ The best way to see a feature added, however, is to submit a pull request.
5656
You can also pass spec paths to run a subset. The `lint` dependency group is
5757
only needed for lint checks; test-only CI jobs install with `BUNDLE_WITHOUT=lint`.
5858

59-
The final `CI` check depends on all test shards, lint, and coverage reporting.
59+
The final `CI` check depends on all test shards and lint, and finalizes coverage reporting.
6060
Repository rulesets can require this single check instead of individual matrix jobs.
6161

6262
* Submit your pull request!

0 commit comments

Comments
 (0)